Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2970)

Unified Diff: chrome/common/channel_info_posix.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/channel_info_mac.mm ('k') | chrome/common/channel_info_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/channel_info_posix.cc
diff --git a/chrome/common/chrome_version_info_posix.cc b/chrome/common/channel_info_posix.cc
similarity index 87%
rename from chrome/common/chrome_version_info_posix.cc
rename to chrome/common/channel_info_posix.cc
index c39e6514d016ae6f7085a1acc4a95d3abc6d7d90..ff55d20af0d4d2cd1efd00e1e29c3e912adb38a4 100644
--- a/chrome/common/chrome_version_info_posix.cc
+++ b/chrome/common/channel_info_posix.cc
@@ -2,10 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/chrome_version_info.h"
+#include "chrome/common/channel_info.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
+#include "components/version_info/version_info.h"
namespace chrome {
@@ -46,16 +47,14 @@ version_info::Channel GetChannelImpl(std::string* modifier_out) {
} // namespace
-// static
-std::string VersionInfo::GetVersionStringModifier() {
+std::string GetChannelString() {
std::string modifier;
GetChannelImpl(&modifier);
return modifier;
}
-// static
-version_info::Channel VersionInfo::GetChannel() {
- return GetChannelImpl(NULL);
+version_info::Channel GetChannel() {
+ return GetChannelImpl(nullptr);
}
} // namespace chrome
« no previous file with comments | « chrome/common/channel_info_mac.mm ('k') | chrome/common/channel_info_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698