chrome/browser/ui/extensions/extension_message_bubble_factory.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_factory.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/extension_message_bubble_factory.cc

diff --git a/chrome/browser/ui/extensions/extension_message_bubble_factory.cc b/chrome/browser/ui/extensions/extension_message_bubble_factory.cc

index 20af4e9bcdda6f2edd5e605d32ac1aedf080bd23..8e3c1e01c65e415c017b27e14a0e14a75696c341 100644

--- a/chrome/browser/ui/extensions/extension_message_bubble_factory.cc

+++ b/chrome/browser/ui/extensions/extension_message_bubble_factory.cc

@@ -15,8 +15,9 @@

#include "chrome/browser/extensions/settings_api_helpers.h"

#include "chrome/browser/extensions/suspicious_extension_bubble_controller.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/common/channel_info.h"

#include "chrome/common/chrome_switches.h"

-#include "chrome/common/chrome_version_info.h"

+#include "components/version_info/version_info.h"

#include "extensions/common/feature_switch.h"

namespace {

@@ -75,7 +76,7 @@ bool EnableDevModeBubble() {

return true;

#if defined(OS_WIN)

- if (chrome::VersionInfo::GetChannel() >= version_info::Channel::BETA)

+ if (chrome::GetChannel() >= version_info::Channel::BETA)

return true;

#endif