Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6569)

Unified Diff: chrome/browser/profiles/chrome_version_service.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/chrome_version_service.cc
diff --git a/chrome/browser/profiles/chrome_version_service.cc b/chrome/browser/profiles/chrome_version_service.cc
index b5315b9cefcc66095d6f2f6ff524d9f21a2817d8..5ca66f550feddc00e4fa428201a721ee432790ab 100644
--- a/chrome/browser/profiles/chrome_version_service.cc
+++ b/chrome/browser/profiles/chrome_version_service.cc
@@ -6,9 +6,9 @@
#include "base/prefs/pref_service.h"
#include "base/version.h"
-#include "chrome/common/chrome_version_info.h"
#include "chrome/common/pref_names.h"
#include "components/pref_registry/pref_registry_syncable.h"
+#include "components/version_info/version_info.h"
// static
void ChromeVersionService::RegisterProfilePrefs(
@@ -30,13 +30,10 @@ std::string ChromeVersionService::GetVersion(PrefService* prefs) {
// static
void ChromeVersionService::OnProfileLoaded(PrefService* prefs,
bool is_new_profile) {
- // Obtain the Chrome version info.
- chrome::VersionInfo version_info;
-
// If this is a new profile set version to current version, otherwise
// (pre-existing profile), leave pref at default value (1.0.0.0) to
// avoid any first-run behavior.
- std::string version = version_info.Version();
+ std::string version = version_info::GetVersionNumber();
if (prefs->FindPreference(prefs::kProfileCreatedByVersion)->
IsDefaultValue() && is_new_profile) {
SetVersion(prefs, version);
« no previous file with comments | « chrome/browser/profile_resetter/resettable_settings_snapshot.cc ('k') | chrome/browser/profiles/profile_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698