chrome/browser/nacl_host/nacl_browser_delegate_impl.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

diff --git a/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc b/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

index 9ccd88077b6bb9a366cda488c5fe5b88dd903aa9..3650dba321b7901e202f683bf72dbc468824868d 100644

--- a/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

+++ b/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

@@ -17,9 +17,9 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/renderer_host/pepper/chrome_browser_pepper_host_factory.h"

+#include "chrome/common/channel_info.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_paths_internal.h"

-#include "chrome/common/chrome_version_info.h"

#include "chrome/common/logging_chrome.h"

#include "chrome/common/pepper_permission_util.h"

#include "content/public/browser/browser_thread.h"

@@ -133,7 +133,7 @@ bool NaClBrowserDelegateImpl::GetUserDirectory(base::FilePath* user_dir) {

}

std::string NaClBrowserDelegateImpl::GetVersionString() const {

- return chrome::VersionInfo().CreateVersionString();

+ return chrome::GetVersionString();

}

ppapi::host::HostFactory* NaClBrowserDelegateImpl::CreatePpapiHostFactory(