chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc ('k') | chrome/browser/history/chrome_history_backend_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc

diff --git a/chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc b/chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc

index cf4a4e38d3a8a54378555f6c952ee9f5235e25ef..9496a9b1cbc501a2beff0a8d5270aa878f2f9378 100644

--- a/chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc

+++ b/chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc

@@ -5,8 +5,9 @@

#include "chrome/browser/guest_view/web_view/context_menu_content_type_web_view.h"

#include "base/command_line.h"

+#include "chrome/common/channel_info.h"

#include "chrome/common/chrome_switches.h"

-#include "chrome/common/chrome_version_info.h"

+#include "components/version_info/version_info.h"

#include "extensions/browser/guest_view/web_view/web_view_guest.h"

#include "extensions/browser/process_manager.h"

#include "extensions/common/extension.h"

@@ -47,8 +48,7 @@ bool ContextMenuContentTypeWebView::SupportsGroup(int group) {

return true;

case ITEM_GROUP_DEVELOPER:

{

- if (chrome::VersionInfo::GetChannel() >=

- version_info::Channel::DEV) {

+ if (chrome::GetChannel() >= version_info::Channel::DEV) {

// Hide dev tools items in guests inside WebUI if we are not running

// canary or tott.

auto web_view_guest =