Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/devtools/remote_debugging_server.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.cc ('k') | chrome/browser/diagnostics/recon_diagnostics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/remote_debugging_server.cc
diff --git a/chrome/browser/devtools/remote_debugging_server.cc b/chrome/browser/devtools/remote_debugging_server.cc
index f3b30eef394ac9bb2820646e9b8bff6357aed418..277097e0d12b215512a01bbb791e26b6f4b95048 100644
--- a/chrome/browser/devtools/remote_debugging_server.cc
+++ b/chrome/browser/devtools/remote_debugging_server.cc
@@ -14,10 +14,10 @@
#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/common/chrome_content_client.h"
#include "chrome/common/chrome_paths.h"
-#include "chrome/common/chrome_version_info.h"
#include "components/devtools_http_handler/devtools_http_handler.h"
#include "components/devtools_http_handler/devtools_http_handler_delegate.h"
#include "components/history/core/browser/top_sites.h"
+#include "components/version_info/version_info.h"
#include "content/public/browser/devtools_frontend_host.h"
#include "grit/browser_resources.h"
#include "net/base/net_errors.h"
@@ -160,15 +160,13 @@ RemoteDebuggingServer::RemoteDebuggingServer(
PathService::Get(chrome::DIR_INSPECTOR, &debug_frontend_dir);
#endif
- chrome::VersionInfo version_info;
-
devtools_http_handler_.reset(new devtools_http_handler::DevToolsHttpHandler(
make_scoped_ptr(new TCPServerSocketFactory(ip, port)),
std::string(),
new ChromeDevToolsHttpHandlerDelegate(),
output_dir,
debug_frontend_dir,
- version_info.ProductNameAndVersionForUserAgent(),
+ version_info::GetProductNameAndVersionForUserAgent(),
::GetUserAgent()));
}
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.cc ('k') | chrome/browser/diagnostics/recon_diagnostics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698