chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm - Issue 1269773002: Cleanup VersionInfo after componentization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/preferences/pref_service_bridge.cc ('k') | chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm

diff --git a/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm b/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm

index e76f5aad1ebe2b0bcae1a7bf04db51d21cb069bc..2018c986de070656000c7d9fa7bd23ff3164d2ad 100644

--- a/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm

+++ b/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm

@@ -15,10 +15,10 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/common/chrome_paths.h"

-#include "chrome/common/chrome_version_info.h"

#include "chrome/common/mac/app_mode_common.h"

#include "chrome/common/mac/app_shim_messages.h"

#include "chrome/test/base/in_process_browser_test.h"

+#include "components/version_info/version_info.h"

#include "content/public/test/test_utils.h"

#include "ipc/ipc_channel_proxy.h"

#include "ipc/ipc_listener.h"

@@ -280,7 +280,7 @@ IN_PROC_BROWSER_TEST_F(AppShimHostManagerBrowserTestSocketFiles,

// Check that the RunningChromeVersion file is correctly written.

base::FilePath version;

EXPECT_TRUE(base::ReadSymbolicLink(version_path_, &version));

- EXPECT_EQ(chrome::VersionInfo().Version(), version.value());

+ EXPECT_EQ(version_info::GetVersionNumber(), version.value());

}

} // namespace