Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/web_applications/web_app_mac_unittest.mm

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/web_applications/web_app.cc ('K') | « chrome/browser/web_applications/web_app_mac.mm ('k') | chrome/browser/web_resource/notification_promo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app_mac_unittest.mm
diff --git a/chrome/browser/web_applications/web_app_mac_unittest.mm b/chrome/browser/web_applications/web_app_mac_unittest.mm
index 101eff0a2133a9ea418868d60006c859f1746a53..43df556d8a0ece09120ac4aebbdc470a57839fdd 100644
--- a/chrome/browser/web_applications/web_app_mac_unittest.mm
+++ b/chrome/browser/web_applications/web_app_mac_unittest.mm
@@ -19,8 +19,8 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
-#include "chrome/common/chrome_version_info.h"
#import "chrome/common/mac/app_mode_common.h"
+#include "components/version_info/version_info.h"
#include "grit/theme_resources.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -135,7 +135,7 @@ TEST_F(WebAppShortcutCreatorTest, CreateShortcuts) {
EXPECT_NSEQ(base::SysUTF8ToNSString(info_->url.spec()),
[plist objectForKey:app_mode::kCrAppModeShortcutURLKey]);
- EXPECT_NSEQ(base::SysUTF8ToNSString(chrome::VersionInfo().Version()),
+ EXPECT_NSEQ(base::SysUTF8ToNSString(version_info::GetVersionNumber()),
[plist objectForKey:app_mode::kCrBundleVersionKey]);
EXPECT_NSEQ(base::SysUTF8ToNSString(info_->version_for_display),
[plist objectForKey:app_mode::kCFBundleShortVersionStringKey]);
« chrome/browser/web_applications/web_app.cc ('K') | « chrome/browser/web_applications/web_app_mac.mm ('k') | chrome/browser/web_resource/notification_promo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698