Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/sync/glue/local_device_info_provider_unittest.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/safe_browsing/protocol_manager.cc ('K') | « chrome/browser/sync/glue/local_device_info_provider_impl.cc ('k') | chrome/browser/sync/glue/sync_backend_host_core.cc » ('j') | chrome/browser/sync/profile_sync_components_factory_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/local_device_info_provider_unittest.cc
diff --git a/chrome/browser/sync/glue/local_device_info_provider_unittest.cc b/chrome/browser/sync/glue/local_device_info_provider_unittest.cc
index d44026480bb2cd26aa6843d7f5768294d7a39dbd..66afcf43137d56aa644717e29cd92e2f38d17867 100644
--- a/chrome/browser/sync/glue/local_device_info_provider_unittest.cc
+++ b/chrome/browser/sync/glue/local_device_info_provider_unittest.cc
@@ -6,7 +6,6 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "chrome/browser/sync/glue/local_device_info_provider_impl.h"
-#include "chrome/common/chrome_version_info.h"
#include "sync/util/get_session_name.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -79,10 +78,9 @@ TEST_F(LocalDeviceInfoProviderTest, GetLocalDeviceInfo) {
EXPECT_EQ(syncer::GetSessionNameSynchronouslyForTesting(),
local_device_info->client_name());
- chrome::VersionInfo version_info;
- EXPECT_EQ(browser_sync::LocalDeviceInfoProviderImpl::MakeUserAgentForSyncApi(
- version_info),
- local_device_info->sync_user_agent());
+ EXPECT_EQ(
+ browser_sync::LocalDeviceInfoProviderImpl::MakeUserAgentForSyncApi(),
+ local_device_info->sync_user_agent());
}
TEST_F(LocalDeviceInfoProviderTest, GetLocalSyncCacheGUID) {
« chrome/browser/safe_browsing/protocol_manager.cc ('K') | « chrome/browser/sync/glue/local_device_info_provider_impl.cc ('k') | chrome/browser/sync/glue/sync_backend_host_core.cc » ('j') | chrome/browser/sync/profile_sync_components_factory_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698