chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_system_impl.cc ('K') | « chrome/browser/extensions/shared_module_service_unittest.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc » ('j') | chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

diff --git a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

index e843cd10fae95b1d0ffe66b042bd7b828db9c18c..3e669970b62cea3c1a817be1fa7b74b884dc576f 100644

--- a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

+++ b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

@@ -12,7 +12,7 @@

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/sync/about_sync_util.h"

#include "chrome/browser/sync/profile_sync_service_factory.h"

-#include "chrome/common/chrome_version_info.h"

+#include "chrome/common/channel_info.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h"

#include "content/public/browser/browser_thread.h"

#include "extensions/browser/extension_registry.h"

@@ -53,8 +53,7 @@ void ChromeInternalLogSource::Fetch(const SysLogsSourceCallback& callback) {

SystemLogsResponse response;

- chrome::VersionInfo version_info;

- response[kChromeVersionTag] = version_info.CreateVersionString();

+ response[kChromeVersionTag] = chrome::GetVersionString();

#if !defined(OS_CHROMEOS)

// On ChromeOS, this will be pulled in from the LSB_RELEASE.