chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_targets_ui.cc ('K') | « chrome/browser/diagnostics/recon_diagnostics.cc ('k') | chrome/browser/extensions/active_tab_unittest.cc » ('j') | chrome/browser/extensions/api/cast_streaming/performance_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc

diff --git a/chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc b/chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc

index cd383b6096886c527a83ffe7c25616fcb277facb..df0814ae44424f3f043bd214fc1239abe4a8d458 100644

--- a/chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc

+++ b/chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.cc

@@ -8,9 +8,9 @@

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/profiles/incognito_helpers.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/common/chrome_version_info.h"

#include "components/enhanced_bookmarks/enhanced_bookmark_model.h"

#include "components/keyed_service/content/browser_context_dependency_manager.h"

+#include "components/version_info/version_info.h"

namespace {

const char kVersionPrefix[] = "chrome.";

@@ -45,7 +45,7 @@ KeyedService* EnhancedBookmarkModelFactory::BuildServiceInstanceFor(

return new EnhancedBookmarkModel(

BookmarkModelFactory::GetForProfile(profile),

- kVersionPrefix + chrome::VersionInfo().Version());

+ kVersionPrefix + version_info::GetVersionNumber());

}

content::BrowserContext* EnhancedBookmarkModelFactory::GetBrowserContextToUse(