chrome/common/extensions/manifest_tests/chrome_manifest_test.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/manifest_tests/chrome_manifest_test.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"	5 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

6	6

7 #include "base/files/file_path.h"	7 #include "base/files/file_path.h"

8 #include "base/path_service.h"	8 #include "base/path_service.h"

9 #include "chrome/common/chrome_paths.h"	9 #include "chrome/common/chrome_paths.h"

10 #include "chrome/common/chrome_version_info.h"	10 #include "components/version_info/version_info.h"

11	11

12 ChromeManifestTest::ChromeManifestTest()	12 ChromeManifestTest::ChromeManifestTest()

13 // CHANNEL_UNKNOWN == trunk.	13 // CHANNEL_UNKNOWN == trunk.

14 : current_channel_(version_info::Channel::UNKNOWN) {}	14 : current_channel_(version_info::Channel::UNKNOWN) {}

15	15

16 ChromeManifestTest::~ChromeManifestTest() {	16 ChromeManifestTest::~ChromeManifestTest() {

17 }	17 }

18	18

19 base::FilePath ChromeManifestTest::GetTestDataDir() {	19 base::FilePath ChromeManifestTest::GetTestDataDir() {

20 base::FilePath path;	20 base::FilePath path;

21 PathService::Get(chrome::DIR_TEST_DATA, &path);	21 PathService::Get(chrome::DIR_TEST_DATA, &path);

22 return path.AppendASCII("extensions").AppendASCII("manifest_tests");	22 return path.AppendASCII("extensions").AppendASCII("manifest_tests");

23 }	23 }

OLD	NEW