Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: chrome/common/chrome_version_info_mac.mm

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/chrome_version_info.h"
6
7 #import <Foundation/Foundation.h>
8
9 #include "base/basictypes.h"
10 #include "base/mac/bundle_locations.h"
11 #include "base/strings/sys_string_conversions.h"
12
13 namespace chrome {
14
15 // static
16 std::string VersionInfo::GetVersionStringModifier() {
17 #if defined(GOOGLE_CHROME_BUILD)
18 // Use the main Chrome application bundle and not the framework bundle.
19 // Keystone keys don't live in the framework.
20 NSBundle* bundle = base::mac::OuterBundle();
21 NSString* channel = [bundle objectForInfoDictionaryKey:@"KSChannelID"];
22
23 // Only ever return "", "unknown", "beta", "dev", or "canary" in a branded
24 // build.
25 if (![bundle objectForInfoDictionaryKey:@"KSProductID"]) {
26 // This build is not Keystone-enabled, it can't have a channel.
27 channel = @"unknown";
28 } else if (!channel) {
29 // For the stable channel, KSChannelID is not set.
30 channel = @"";
31 } else if ([channel isEqual:@"beta"] ||
32 [channel isEqual:@"dev"] ||
33 [channel isEqual:@"canary"]) {
34 // do nothing.
35 } else {
36 channel = @"unknown";
37 }
38
39 return base::SysNSStringToUTF8(channel);
40 #else
41 return std::string();
42 #endif
43 }
44
45 // static
46 version_info::Channel VersionInfo::GetChannel() {
47 #if defined(GOOGLE_CHROME_BUILD)
48 std::string channel = GetVersionStringModifier();
49 if (channel.empty()) {
50 return version_info::Channel::STABLE;
51 } else if (channel == "beta") {
52 return version_info::Channel::BETA;
53 } else if (channel == "dev") {
54 return version_info::Channel::DEV;
55 } else if (channel == "canary") {
56 return version_info::Channel::CANARY;
57 }
58 #endif
59
60 return version_info::Channel::UNKNOWN;
61 }
62
63 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/common/chrome_version_info_chromeos.cc ('k') | chrome/common/chrome_version_info_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698