Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: chrome/common/chrome_content_client.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/channel_info_win.cc ('k') | chrome/common/chrome_content_client_ios.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_content_client.h" 5 #include "chrome/common/chrome_content_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/debug/crash_logging.h" 8 #include "base/debug/crash_logging.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/json/json_reader.h" 10 #include "base/json/json_reader.h"
11 #include "base/path_service.h" 11 #include "base/path_service.h"
12 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
13 #include "base/strings/string_number_conversions.h" 13 #include "base/strings/string_number_conversions.h"
14 #include "base/strings/string_split.h" 14 #include "base/strings/string_split.h"
15 #include "base/strings/string_util.h" 15 #include "base/strings/string_util.h"
16 #include "base/strings/stringprintf.h" 16 #include "base/strings/stringprintf.h"
17 #include "base/strings/utf_string_conversions.h" 17 #include "base/strings/utf_string_conversions.h"
18 #include "build/build_config.h" 18 #include "build/build_config.h"
19 #include "chrome/common/child_process_logging.h" 19 #include "chrome/common/child_process_logging.h"
20 #include "chrome/common/chrome_constants.h" 20 #include "chrome/common/chrome_constants.h"
21 #include "chrome/common/chrome_paths.h" 21 #include "chrome/common/chrome_paths.h"
22 #include "chrome/common/chrome_switches.h" 22 #include "chrome/common/chrome_switches.h"
23 #include "chrome/common/chrome_version_info.h"
24 #include "chrome/common/crash_keys.h" 23 #include "chrome/common/crash_keys.h"
25 #include "chrome/common/pepper_flash.h" 24 #include "chrome/common/pepper_flash.h"
26 #include "chrome/common/secure_origin_whitelist.h" 25 #include "chrome/common/secure_origin_whitelist.h"
27 #include "chrome/common/url_constants.h" 26 #include "chrome/common/url_constants.h"
28 #include "chrome/grit/common_resources.h" 27 #include "chrome/grit/common_resources.h"
29 #include "components/dom_distiller/core/url_constants.h" 28 #include "components/dom_distiller/core/url_constants.h"
29 #include "components/version_info/version_info.h"
30 #include "content/public/common/content_constants.h" 30 #include "content/public/common/content_constants.h"
31 #include "content/public/common/content_switches.h" 31 #include "content/public/common/content_switches.h"
32 #include "content/public/common/url_constants.h" 32 #include "content/public/common/url_constants.h"
33 #include "content/public/common/user_agent.h" 33 #include "content/public/common/user_agent.h"
34 #include "extensions/common/constants.h" 34 #include "extensions/common/constants.h"
35 #include "gpu/config/gpu_info.h" 35 #include "gpu/config/gpu_info.h"
36 #include "net/http/http_util.h" 36 #include "net/http/http_util.h"
37 #include "ui/base/l10n/l10n_util.h" 37 #include "ui/base/l10n/l10n_util.h"
38 #include "ui/base/layout.h" 38 #include "ui/base/layout.h"
39 #include "ui/base/resource/resource_bundle.h" 39 #include "ui/base/resource/resource_bundle.h"
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 Version version; 368 Version version;
369 if (!chrome::CheckPepperFlashManifest(*manifest, &version)) 369 if (!chrome::CheckPepperFlashManifest(*manifest, &version))
370 return false; 370 return false;
371 371
372 *plugin = CreatePepperFlashInfo(flash_filename, version.GetString()); 372 *plugin = CreatePepperFlashInfo(flash_filename, version.GetString());
373 return true; 373 return true;
374 } 374 }
375 #endif // defined(ENABLE_PLUGINS) 375 #endif // defined(ENABLE_PLUGINS)
376 376
377 std::string GetProduct() { 377 std::string GetProduct() {
378 chrome::VersionInfo version_info; 378 return version_info::GetProductNameAndVersionForUserAgent();
379 return version_info.ProductNameAndVersionForUserAgent();
380 } 379 }
381 380
382 } // namespace 381 } // namespace
383 382
384 std::string GetUserAgent() { 383 std::string GetUserAgent() {
385 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); 384 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
386 if (command_line->HasSwitch(switches::kUserAgent)) { 385 if (command_line->HasSwitch(switches::kUserAgent)) {
387 std::string ua = command_line->GetSwitchValueASCII(switches::kUserAgent); 386 std::string ua = command_line->GetSwitchValueASCII(switches::kUserAgent);
388 if (net::HttpUtil::IsValidHeaderValue(ua)) 387 if (net::HttpUtil::IsValidHeaderValue(ua))
389 return ua; 388 return ua;
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 schemes->insert(content::kChromeUIScheme); 552 schemes->insert(content::kChromeUIScheme);
554 schemes->insert(extensions::kExtensionScheme); 553 schemes->insert(extensions::kExtensionScheme);
555 schemes->insert(extensions::kExtensionResourceScheme); 554 schemes->insert(extensions::kExtensionResourceScheme);
556 GetSecureOriginWhitelist(origins); 555 GetSecureOriginWhitelist(origins);
557 } 556 }
558 557
559 void ChromeContentClient::AddServiceWorkerSchemes( 558 void ChromeContentClient::AddServiceWorkerSchemes(
560 std::set<std::string>* schemes) { 559 std::set<std::string>* schemes) {
561 schemes->insert(extensions::kExtensionScheme); 560 schemes->insert(extensions::kExtensionScheme);
562 } 561 }
OLDNEW
« no previous file with comments | « chrome/common/channel_info_win.cc ('k') | chrome/common/chrome_content_client_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698