chrome/browser/extensions/shared_module_service_unittest.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/shared_module_service_unittest.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/service_worker_apitest.cc ('k') | chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include "chrome/browser/extensions/shared_module_service.h"

	6

5 #include "base/memory/ref_counted.h"	7 #include "base/memory/ref_counted.h"

6 #include "base/memory/scoped_ptr.h"	8 #include "base/memory/scoped_ptr.h"

7 #include "base/strings/string16.h"	9 #include "base/strings/string16.h"

8 #include "base/values.h"	10 #include "base/values.h"

9 #include "chrome/browser/extensions/extension_service.h"	11 #include "chrome/browser/extensions/extension_service.h"

10 #include "chrome/browser/extensions/extension_service_test_base.h"	12 #include "chrome/browser/extensions/extension_service_test_base.h"

11 #include "chrome/browser/extensions/pending_extension_manager.h"	13 #include "chrome/browser/extensions/pending_extension_manager.h"

12 #include "chrome/browser/extensions/shared_module_service.h"

13 #include "chrome/common/extensions/features/feature_channel.h"	14 #include "chrome/common/extensions/features/feature_channel.h"

14 #include "components/crx_file/id_util.h"	15 #include "components/crx_file/id_util.h"

	16 #include "components/version_info/version_info.h"

15 #include "extensions/browser/extension_registry.h"	17 #include "extensions/browser/extension_registry.h"

16 #include "extensions/browser/install_flag.h"	18 #include "extensions/browser/install_flag.h"

17 #include "extensions/browser/uninstall_reason.h"	19 #include "extensions/browser/uninstall_reason.h"

18 #include "extensions/common/extension_builder.h"	20 #include "extensions/common/extension_builder.h"

19 #include "extensions/common/value_builder.h"	21 #include "extensions/common/value_builder.h"

20 #include "sync/api/string_ordinal.h"	22 #include "sync/api/string_ordinal.h"

21	23

22 namespace extensions {	24 namespace extensions {

23	25

24 namespace {	26 namespace {

(...skipping 244 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
269 nonwhitelisted_id,	271 nonwhitelisted_id,

270 "1.0");	272 "1.0");

271 // This should succeed because only CRX installer (and by extension the	273 // This should succeed because only CRX installer (and by extension the

272 // WebStore Installer) checks the shared module whitelist. InstallExtension	274 // WebStore Installer) checks the shared module whitelist. InstallExtension

273 // bypasses the whitelist check because the SharedModuleService does not	275 // bypasses the whitelist check because the SharedModuleService does not

274 // care about whitelists.	276 // care about whitelists.

275 EXPECT_TRUE(InstallExtension(nonwhitelisted_extension.get(), false));	277 EXPECT_TRUE(InstallExtension(nonwhitelisted_extension.get(), false));

276 }	278 }

277	279

278 } // namespace extensions	280 } // namespace extensions

OLD	NEW