Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: chrome/browser/extensions/chrome_extensions_browser_client.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/chrome_extensions_browser_client.h" 5 #include "chrome/browser/extensions/chrome_extensions_browser_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/version.h" 8 #include "base/version.h"
9 #include "chrome/browser/app_mode/app_mode_utils.h" 9 #include "chrome/browser/app_mode/app_mode_utils.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 13 matching lines...) Expand all
24 #include "chrome/browser/extensions/chrome_url_request_util.h" 24 #include "chrome/browser/extensions/chrome_url_request_util.h"
25 #include "chrome/browser/extensions/error_console/error_console.h" 25 #include "chrome/browser/extensions/error_console/error_console.h"
26 #include "chrome/browser/extensions/event_router_forwarder.h" 26 #include "chrome/browser/extensions/event_router_forwarder.h"
27 #include "chrome/browser/extensions/extension_system_factory.h" 27 #include "chrome/browser/extensions/extension_system_factory.h"
28 #include "chrome/browser/extensions/extension_util.h" 28 #include "chrome/browser/extensions/extension_util.h"
29 #include "chrome/browser/extensions/menu_manager.h" 29 #include "chrome/browser/extensions/menu_manager.h"
30 #include "chrome/browser/external_protocol/external_protocol_handler.h" 30 #include "chrome/browser/external_protocol/external_protocol_handler.h"
31 #include "chrome/browser/net/chrome_net_log.h" 31 #include "chrome/browser/net/chrome_net_log.h"
32 #include "chrome/browser/profiles/profile.h" 32 #include "chrome/browser/profiles/profile.h"
33 #include "chrome/browser/profiles/profile_manager.h" 33 #include "chrome/browser/profiles/profile_manager.h"
34 #include "chrome/common/channel_info.h"
34 #include "chrome/common/chrome_paths.h" 35 #include "chrome/common/chrome_paths.h"
35 #include "chrome/common/chrome_switches.h" 36 #include "chrome/common/chrome_switches.h"
36 #include "chrome/common/chrome_version_info.h"
37 #include "chrome/common/extensions/features/feature_channel.h" 37 #include "chrome/common/extensions/features/feature_channel.h"
38 #include "chrome/common/pref_names.h" 38 #include "chrome/common/pref_names.h"
39 #include "components/version_info/version_info.h"
39 #include "content/public/browser/render_process_host.h" 40 #include "content/public/browser/render_process_host.h"
40 #include "extensions/browser/api/generated_api_registration.h" 41 #include "extensions/browser/api/generated_api_registration.h"
41 #include "extensions/browser/extension_function_registry.h" 42 #include "extensions/browser/extension_function_registry.h"
42 #include "extensions/browser/extension_prefs.h" 43 #include "extensions/browser/extension_prefs.h"
43 #include "extensions/browser/mojo/service_registration.h" 44 #include "extensions/browser/mojo/service_registration.h"
44 #include "extensions/browser/pref_names.h" 45 #include "extensions/browser/pref_names.h"
45 #include "extensions/browser/url_request_util.h" 46 #include "extensions/browser/url_request_util.h"
46 47
47 #if defined(OS_CHROMEOS) 48 #if defined(OS_CHROMEOS)
48 #include "chrome/browser/chromeos/profiles/profile_helper.h" 49 #include "chrome/browser/chromeos/profiles/profile_helper.h"
49 #include "chrome/browser/extensions/updater/chromeos_extension_cache_delegate.h" 50 #include "chrome/browser/extensions/updater/chromeos_extension_cache_delegate.h"
50 #include "chrome/browser/extensions/updater/extension_cache_impl.h" 51 #include "chrome/browser/extensions/updater/extension_cache_impl.h"
51 #include "chromeos/chromeos_switches.h" 52 #include "chromeos/chromeos_switches.h"
52 #else 53 #else
53 #include "extensions/browser/updater/null_extension_cache.h" 54 #include "extensions/browser/updater/null_extension_cache.h"
54 #endif 55 #endif
55 56
56 namespace extensions { 57 namespace extensions {
57 58
58 ChromeExtensionsBrowserClient::ChromeExtensionsBrowserClient() { 59 ChromeExtensionsBrowserClient::ChromeExtensionsBrowserClient() {
59 process_manager_delegate_.reset(new ChromeProcessManagerDelegate); 60 process_manager_delegate_.reset(new ChromeProcessManagerDelegate);
60 api_client_.reset(new ChromeExtensionsAPIClient); 61 api_client_.reset(new ChromeExtensionsAPIClient);
61 // Only set if it hasn't already been set (e.g. by a test). 62 // Only set if it hasn't already been set (e.g. by a test).
62 if (GetCurrentChannel() == GetDefaultChannel()) 63 if (GetCurrentChannel() == GetDefaultChannel())
63 SetCurrentChannel(chrome::VersionInfo::GetChannel()); 64 SetCurrentChannel(chrome::GetChannel());
64 resource_manager_.reset(new ChromeComponentExtensionResourceManager()); 65 resource_manager_.reset(new ChromeComponentExtensionResourceManager());
65 } 66 }
66 67
67 ChromeExtensionsBrowserClient::~ChromeExtensionsBrowserClient() {} 68 ChromeExtensionsBrowserClient::~ChromeExtensionsBrowserClient() {}
68 69
69 bool ChromeExtensionsBrowserClient::IsShuttingDown() { 70 bool ChromeExtensionsBrowserClient::IsShuttingDown() {
70 return g_browser_process->IsShuttingDown(); 71 return g_browser_process->IsShuttingDown();
71 } 72 }
72 73
73 bool ChromeExtensionsBrowserClient::AreExtensionsDisabled( 74 bool ChromeExtensionsBrowserClient::AreExtensionsDisabled(
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 return false; 199 return false;
199 200
200 PrefService* pref_service = extension_prefs->pref_service(); 201 PrefService* pref_service = extension_prefs->pref_service();
201 base::Version last_version; 202 base::Version last_version;
202 if (pref_service->HasPrefPath(pref_names::kLastChromeVersion)) { 203 if (pref_service->HasPrefPath(pref_names::kLastChromeVersion)) {
203 std::string last_version_str = 204 std::string last_version_str =
204 pref_service->GetString(pref_names::kLastChromeVersion); 205 pref_service->GetString(pref_names::kLastChromeVersion);
205 last_version = base::Version(last_version_str); 206 last_version = base::Version(last_version_str);
206 } 207 }
207 208
208 chrome::VersionInfo current_version_info; 209 std::string current_version = version_info::GetVersionNumber();
209 std::string current_version = current_version_info.Version();
210 pref_service->SetString(pref_names::kLastChromeVersion, 210 pref_service->SetString(pref_names::kLastChromeVersion,
211 current_version); 211 current_version);
212 212
213 // If there was no version string in prefs, assume we're out of date. 213 // If there was no version string in prefs, assume we're out of date.
214 if (!last_version.IsValid()) 214 if (!last_version.IsValid())
215 return true; 215 return true;
216 216
217 return last_version.IsOlderThan(current_version); 217 return last_version.IsOlderThan(current_version);
218 } 218 }
219 219
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 return extension_cache_.get(); 303 return extension_cache_.get();
304 } 304 }
305 305
306 bool ChromeExtensionsBrowserClient::IsBackgroundUpdateAllowed() { 306 bool ChromeExtensionsBrowserClient::IsBackgroundUpdateAllowed() {
307 return !base::CommandLine::ForCurrentProcess()->HasSwitch( 307 return !base::CommandLine::ForCurrentProcess()->HasSwitch(
308 switches::kDisableBackgroundNetworking); 308 switches::kDisableBackgroundNetworking);
309 } 309 }
310 310
311 bool ChromeExtensionsBrowserClient::IsMinBrowserVersionSupported( 311 bool ChromeExtensionsBrowserClient::IsMinBrowserVersionSupported(
312 const std::string& min_version) { 312 const std::string& min_version) {
313 chrome::VersionInfo version_info; 313 base::Version browser_version =
314 base::Version browser_version = base::Version(version_info.Version()); 314 base::Version(version_info::GetVersionNumber());
315 Version browser_min_version(min_version); 315 Version browser_min_version(min_version);
316 if (browser_version.IsValid() && browser_min_version.IsValid() && 316 if (browser_version.IsValid() && browser_min_version.IsValid() &&
317 browser_min_version.CompareTo(browser_version) > 0) { 317 browser_min_version.CompareTo(browser_version) > 0) {
318 return false; 318 return false;
319 } 319 }
320 return true; 320 return true;
321 } 321 }
322 322
323 ExtensionWebContentsObserver* 323 ExtensionWebContentsObserver*
324 ChromeExtensionsBrowserClient::GetExtensionWebContentsObserver( 324 ChromeExtensionsBrowserClient::GetExtensionWebContentsObserver(
(...skipping 14 matching lines...) Expand all
339 ->GetBrowserContext(); 339 ->GetBrowserContext();
340 340
341 // Clean up context menus for the WebView. 341 // Clean up context menus for the WebView.
342 auto menu_manager = 342 auto menu_manager =
343 MenuManager::Get(Profile::FromBrowserContext(browser_context)); 343 MenuManager::Get(Profile::FromBrowserContext(browser_context));
344 menu_manager->RemoveAllContextItems( 344 menu_manager->RemoveAllContextItems(
345 MenuItem::ExtensionKey("", embedder_process_id, view_instance_id)); 345 MenuItem::ExtensionKey("", embedder_process_id, view_instance_id));
346 } 346 }
347 347
348 } // namespace extensions 348 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698