Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: chrome/app/chrome_crash_reporter_client.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/android/chrome_android_initializer.cc ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/chrome_crash_reporter_client.h" 5 #include "chrome/app/chrome_crash_reporter_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/environment.h" 8 #include "base/environment.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 27 matching lines...) Expand all
38 38
39 #if defined(OS_POSIX) 39 #if defined(OS_POSIX)
40 #include "base/debug/dump_without_crashing.h" 40 #include "base/debug/dump_without_crashing.h"
41 #endif 41 #endif
42 42
43 #if defined(OS_ANDROID) 43 #if defined(OS_ANDROID)
44 #include "chrome/common/descriptors_android.h" 44 #include "chrome/common/descriptors_android.h"
45 #endif 45 #endif
46 46
47 #if defined(OS_CHROMEOS) 47 #if defined(OS_CHROMEOS)
48 #include "chrome/common/chrome_version_info.h" 48 #include "chrome/common/channel_info.h"
49 #include "chromeos/chromeos_switches.h" 49 #include "chromeos/chromeos_switches.h"
50 #include "components/version_info/version_info.h"
50 #endif 51 #endif
51 52
52 namespace chrome { 53 namespace chrome {
53 54
54 namespace { 55 namespace {
55 56
56 #if defined(OS_WIN) 57 #if defined(OS_WIN)
57 // This is the minimum version of google update that is required for deferred 58 // This is the minimum version of google update that is required for deferred
58 // crash uploads to work. 59 // crash uploads to work.
59 const char kMinUpdateVersion[] = "1.3.21.115"; 60 const char kMinUpdateVersion[] = "1.3.21.115";
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 #if defined(GOOGLE_CHROME_BUILD) 316 #if defined(GOOGLE_CHROME_BUILD)
316 bool is_official_chrome_build = true; 317 bool is_official_chrome_build = true;
317 #else 318 #else
318 bool is_official_chrome_build = false; 319 bool is_official_chrome_build = false;
319 #endif 320 #endif
320 321
321 #if defined(OS_CHROMEOS) 322 #if defined(OS_CHROMEOS)
322 bool is_guest_session = base::CommandLine::ForCurrentProcess()->HasSwitch( 323 bool is_guest_session = base::CommandLine::ForCurrentProcess()->HasSwitch(
323 chromeos::switches::kGuestSession); 324 chromeos::switches::kGuestSession);
324 bool is_stable_channel = 325 bool is_stable_channel =
325 chrome::VersionInfo::GetChannel() == version_info::Channel::STABLE; 326 chrome::GetChannel() == version_info::Channel::STABLE;
326 327
327 if (is_guest_session && is_stable_channel) 328 if (is_guest_session && is_stable_channel)
328 return false; 329 return false;
329 #endif // defined(OS_CHROMEOS) 330 #endif // defined(OS_CHROMEOS)
330 331
331 #if defined(OS_ANDROID) 332 #if defined(OS_ANDROID)
332 // TODO(jcivelli): we should not initialize the crash-reporter when it was not 333 // TODO(jcivelli): we should not initialize the crash-reporter when it was not
333 // enabled. Right now if it is disabled we still generate the minidumps but we 334 // enabled. Right now if it is disabled we still generate the minidumps but we
334 // do not upload them. 335 // do not upload them.
335 return is_official_chrome_build; 336 return is_official_chrome_build;
(...skipping 12 matching lines...) Expand all
348 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 349 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
349 const std::string& process_type) { 350 const std::string& process_type) {
350 return process_type == switches::kRendererProcess || 351 return process_type == switches::kRendererProcess ||
351 process_type == switches::kPluginProcess || 352 process_type == switches::kPluginProcess ||
352 process_type == switches::kPpapiPluginProcess || 353 process_type == switches::kPpapiPluginProcess ||
353 process_type == switches::kZygoteProcess || 354 process_type == switches::kZygoteProcess ||
354 process_type == switches::kGpuProcess; 355 process_type == switches::kGpuProcess;
355 } 356 }
356 357
357 } // namespace chrome 358 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/app/android/chrome_android_initializer.cc ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698