chrome/app/android/chrome_android_initializer.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/android/chrome_android_initializer.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/app/android/chrome_android_initializer.h"	5 #include "chrome/app/android/chrome_android_initializer.h"

6	6

7 #include "base/android/library_loader/library_loader_hooks.h"	7 #include "base/android/library_loader/library_loader_hooks.h"

8 #include "chrome/app/android/chrome_main_delegate_android.h"	8 #include "chrome/app/android/chrome_main_delegate_android.h"

9 #include "chrome/common/chrome_version_info.h"	9 #include "components/version_info/version_info.h"

10 #include "content/public/app/content_main.h"	10 #include "content/public/app/content_main.h"

11	11

12 bool RunChrome() {	12 bool RunChrome() {

13 // Pass the library version number to content so that we can check it from the	13 // Pass the library version number to content so that we can check it from the

14 // Java side before continuing initialization	14 // Java side before continuing initialization

15 chrome::VersionInfo vi;	15 base::android::SetVersionNumber(version_info::GetVersionNumber().c_str());

16 base::android::SetVersionNumber(vi.Version().c_str());

17 content::SetContentMainDelegate(ChromeMainDelegateAndroid::Create());	16 content::SetContentMainDelegate(ChromeMainDelegateAndroid::Create());

18	17

19 return true;	18 return true;

20 }	19 }

OLD	NEW