chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/web_applications/web_app.cc ('K') | « chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc ('k') | chrome/common/extensions/manifest_tests/chrome_manifest_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/extensions/manifest_handlers/ui_overrides_handler.h"	5 #include "chrome/common/extensions/manifest_handlers/ui_overrides_handler.h"

6	6

7 #include "base/command_line.h"	7 #include "base/command_line.h"

8 #include "base/json/json_string_value_serializer.h"	8 #include "base/json/json_string_value_serializer.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "chrome/common/extensions/features/feature_channel.h"	10 #include "chrome/common/extensions/features/feature_channel.h"

	11 #include "components/version_info/version_info.h"

11 #include "extensions/common/error_utils.h"	12 #include "extensions/common/error_utils.h"

12 #include "extensions/common/extension.h"	13 #include "extensions/common/extension.h"

13 #include "extensions/common/manifest_constants.h"	14 #include "extensions/common/manifest_constants.h"

14 #include "extensions/common/manifest_url_handlers.h"	15 #include "extensions/common/manifest_url_handlers.h"

15 #include "testing/gtest/include/gtest/gtest.h"	16 #include "testing/gtest/include/gtest/gtest.h"

16	17

17 namespace {	18 namespace {

18	19

19 const char kManifest[] = "{"	20 const char kManifest[] = "{"

20 " \"version\" : \"1.0.0.0\","	21 " \"version\" : \"1.0.0.0\","

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91 &error);	92 &error);

92 EXPECT_FALSE(extension.get());	93 EXPECT_FALSE(extension.get());

93 EXPECT_EQ(	94 EXPECT_EQ(

94 extensions::ErrorUtils::FormatErrorMessage(	95 extensions::ErrorUtils::FormatErrorMessage(

95 extensions::manifest_errors::kInvalidEmptyDictionary,	96 extensions::manifest_errors::kInvalidEmptyDictionary,

96 extensions::manifest_keys::kUIOverride),	97 extensions::manifest_keys::kUIOverride),

97 error);	98 error);

98 }	99 }

99	100

100 } // namespace	101 } // namespace

OLD	NEW