chrome/browser/history/DEPS - Issue 1269773002: Cleanup VersionInfo after componentization.

Side by Side Diff: chrome/browser/history/DEPS

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc ('K') | « chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc ('k') | chrome/browser/history/chrome_history_backend_client.cc » ('j') | chrome/browser/history/chrome_history_client.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 include_rules = [

2 # History is being made into a Browser Component (http://crbug.com/370850), so

3 # we have these basic rules followed by temporary exceptions. Please don't

4 # add to the list of exceptions!

5 #

6 # Please send reviews to sdefresne@chromium.org when adding dependencies to

7 # this list.

8 "-chrome/browser",

9 "-components",

10

11 "+chrome/browser/history",

12 "-chrome/browser/history/android",

13

14 "+components/history",

15 "+components/favicon_base",

16 "+components/keyed_service/core",

17 "+components/signin/core/browser",

18

19 # TODO(sdefresne): Bring this list to zero.

20 #

21 # Do not add to the list of temporarily-allowed dependencies below,

22 # and please do not introduce more #includes of these files.

23 "!chrome/browser/chrome_notification_types.h",

24 "!chrome/browser/prerender/prerender_contents.h",

25 "!chrome/browser/prerender/prerender_manager.h",

26 "!chrome/browser/prerender/prerender_manager_factory.h",

27 "!chrome/browser/profiles/incognito_helpers.h",

28 "!chrome/browser/profiles/profile.h",

29 "!chrome/browser/profiles/profile_manager.h",

30 "!chrome/browser/ui/browser.h",

31 "!chrome/browser/ui/browser_finder.h",

32 "!components/dom_distiller/core/url_constants.h",

33 ]

34

35 specific_include_rules = {

36 # Browser tests, by definition, need access to the browser objects.

37 '.*_(api\|browser\|)test\.cc': [

38 "+chrome/browser",

39 ],

40 # chrome_.* and .*_factory won't be componentized as they belong to the

41 # embedder, so they can depend on other feature in chrome/. Same thing

42 # for android specific code.

43 '(chrome_.\|._factory)\.(cc\|h)': [

44 "+chrome/browser/bookmarks/bookmark_model_factory.h",

45 "+chrome/browser/bookmarks/chrome_bookmark_client.h",

46 "+chrome/browser/bookmarks/chrome_bookmark_client_factory.h",

47 "+chrome/browser/content_settings/cookie_settings.h",

48 "+chrome/browser/history/android/android_provider_backend.h",

49 "+chrome/browser/signin/profile_oauth2_token_service_factory.h",

50 "+chrome/browser/signin/signin_manager_factory.h",

51 "+chrome/browser/sync/profile_sync_service.h",

52 "+chrome/browser/sync/profile_sync_service_factory.h",

53 "+chrome/browser/ui/profile_error_dialog.h",

54 "+components/bookmarks/browser",

55 "+components/keyed_service/content",

56 "+components/pref_registry",

57 ],

58 # Those files will move to //components/history/content/browser and thus

59 # can depend on //content even indirectly.

60 'content_.*\.(cc\|h)': [

61 "+components/visitedlink/browser",

62 ],

63 # TODO(sdefresne): Bring this list to zero.

64 #

65 # Do not add to the list of temporarily-allowed dependencies below,

66 # and please do not introduce more #includes of these files.

67 '._[a-z]test\.cc': [

68 "!chrome/browser/bookmarks/bookmark_model_factory.h",

69 "!chrome/browser/signin/profile_oauth2_token_service_factory.h",

70 "!chrome/browser/signin/signin_manager_factory.h",

71 "!chrome/browser/sync/profile_sync_service.h",

72 "!chrome/browser/sync/profile_sync_service_factory.h",

73 "!chrome/browser/sync/profile_sync_service_mock.h",

74 "!components/bookmarks/test/bookmark_test_helpers.h",

75 ]

76 }

OLD	NEW