Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269743003: Dont try to draw glyphs with unexpected mask formats (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Dont try to draw glyphs with unexpected mask formats BUG=510931 Committed: https://skia.googlesource.com/skia/+/4f19ca325e8d0122e0a04345272d17e674460806

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 3

Patch Set 3 : tweaks #

Patch Set 4 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M src/gpu/GrAtlasTextContext.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrBatchFontCache.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrFontScaler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrFontScaler.cpp View 1 2 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
joshualitt
ptal
5 years, 4 months ago (2015-07-30 14:06:24 UTC) #2
joshualitt
On 2015/07/30 14:06:24, joshualitt wrote: > ptal as a follow on I will create a ...
5 years, 4 months ago (2015-07-30 14:18:33 UTC) #3
bsalomon
On 2015/07/30 14:06:24, joshualitt wrote: > ptal I defer to someone who knows the code, ...
5 years, 4 months ago (2015-07-30 14:21:58 UTC) #4
robertphillips
lgtm https://codereview.chromium.org/1269743003/diff/20001/src/gpu/GrFontScaler.cpp File src/gpu/GrFontScaler.cpp (right): https://codereview.chromium.org/1269743003/diff/20001/src/gpu/GrFontScaler.cpp#newcode116 src/gpu/GrFontScaler.cpp:116: // uncommon so for now we just draw ...
5 years, 4 months ago (2015-07-30 14:36:27 UTC) #5
jvanverth1
On 2015/07/30 14:21:58, bsalomon wrote: > On 2015/07/30 14:06:24, joshualitt wrote: > > ptal > ...
5 years, 4 months ago (2015-07-30 14:37:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269743003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269743003/60001
5 years, 4 months ago (2015-07-30 14:47:25 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 14:59:22 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/4f19ca325e8d0122e0a04345272d17e674460806

Powered by Google App Engine
This is Rietveld 408576698