Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1269743002: Take into account freed global handles for heap growing. (Closed)

Created:
5 years, 4 months ago by ulan
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Take into account freed global handles for heap growing. This partially brings back the heuristic from v8 4.44. BUG= Committed: https://crrev.com/d5419bb6b4aad8b4e6cc1cb55dd9af0a1889765c Cr-Commit-Position: refs/heads/master@{#29947}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 3 chunks +11 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
ulan
ptal https://codereview.chromium.org/1269743002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1269743002/diff/1/src/heap/heap.cc#newcode5659 src/heap/heap.cc:5659: const int kFreedGlobalHandlesThreshold = 700; These numbers are ...
5 years, 4 months ago (2015-07-30 13:58:32 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-07-30 14:47:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269743002/1
5 years, 4 months ago (2015-07-31 08:29:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 09:00:05 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 09:00:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5419bb6b4aad8b4e6cc1cb55dd9af0a1889765c
Cr-Commit-Position: refs/heads/master@{#29947}

Powered by Google App Engine
This is Rietveld 408576698