Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1269733002: Debugger: correctly redirect code with no stack check. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove printf Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 if (scope()->HasIllegalRedeclaration()) { 359 if (scope()->HasIllegalRedeclaration()) {
360 Comment cmnt(masm_, "[ Declarations"); 360 Comment cmnt(masm_, "[ Declarations");
361 scope()->VisitIllegalRedeclaration(this); 361 scope()->VisitIllegalRedeclaration(this);
362 362
363 } else { 363 } else {
364 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS); 364 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS);
365 { Comment cmnt(masm_, "[ Declarations"); 365 { Comment cmnt(masm_, "[ Declarations");
366 VisitDeclarations(scope()->declarations()); 366 VisitDeclarations(scope()->declarations());
367 } 367 }
368 368
369 // Assert that the declarations do not use ICs. Otherwise the debugger
370 // won't be able to redirect a PC at an IC to the correct IC in newly
371 // recompiled code.
372 DCHECK_EQ(0, ic_total_count_);
373
369 { Comment cmnt(masm_, "[ Stack check"); 374 { Comment cmnt(masm_, "[ Stack check");
370 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS); 375 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS);
371 Label ok; 376 Label ok;
372 __ LoadRoot(at, Heap::kStackLimitRootIndex); 377 __ LoadRoot(at, Heap::kStackLimitRootIndex);
373 __ Branch(&ok, hs, sp, Operand(at)); 378 __ Branch(&ok, hs, sp, Operand(at));
374 Handle<Code> stack_check = isolate()->builtins()->StackCheck(); 379 Handle<Code> stack_check = isolate()->builtins()->StackCheck();
375 PredictableCodeSizeScope predictable(masm_, 380 PredictableCodeSizeScope predictable(masm_,
376 masm_->CallSize(stack_check, RelocInfo::CODE_TARGET)); 381 masm_->CallSize(stack_check, RelocInfo::CODE_TARGET));
377 __ Call(stack_check, RelocInfo::CODE_TARGET); 382 __ Call(stack_check, RelocInfo::CODE_TARGET);
378 __ bind(&ok); 383 __ bind(&ok);
(...skipping 5051 matching lines...) Expand 10 before | Expand all | Expand 10 after
5430 reinterpret_cast<uint32_t>( 5435 reinterpret_cast<uint32_t>(
5431 isolate->builtins()->OsrAfterStackCheck()->entry())); 5436 isolate->builtins()->OsrAfterStackCheck()->entry()));
5432 return OSR_AFTER_STACK_CHECK; 5437 return OSR_AFTER_STACK_CHECK;
5433 } 5438 }
5434 5439
5435 5440
5436 } // namespace internal 5441 } // namespace internal
5437 } // namespace v8 5442 } // namespace v8
5438 5443
5439 #endif // V8_TARGET_ARCH_MIPS 5444 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698