Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1269733002: Debugger: correctly redirect code with no stack check. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove printf Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 if (scope()->HasIllegalRedeclaration()) { 341 if (scope()->HasIllegalRedeclaration()) {
342 Comment cmnt(masm_, "[ Declarations"); 342 Comment cmnt(masm_, "[ Declarations");
343 scope()->VisitIllegalRedeclaration(this); 343 scope()->VisitIllegalRedeclaration(this);
344 344
345 } else { 345 } else {
346 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS); 346 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS);
347 { Comment cmnt(masm_, "[ Declarations"); 347 { Comment cmnt(masm_, "[ Declarations");
348 VisitDeclarations(scope()->declarations()); 348 VisitDeclarations(scope()->declarations());
349 } 349 }
350 350
351 // Assert that the declarations do not use ICs. Otherwise the debugger
352 // won't be able to redirect a PC at an IC to the correct IC in newly
353 // recompiled code.
354 DCHECK_EQ(0, ic_total_count_);
355
351 { Comment cmnt(masm_, "[ Stack check"); 356 { Comment cmnt(masm_, "[ Stack check");
352 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS); 357 PrepareForBailoutForId(BailoutId::Declarations(), NO_REGISTERS);
353 Label ok; 358 Label ok;
354 __ LoadRoot(ip, Heap::kStackLimitRootIndex); 359 __ LoadRoot(ip, Heap::kStackLimitRootIndex);
355 __ cmp(sp, Operand(ip)); 360 __ cmp(sp, Operand(ip));
356 __ b(hs, &ok); 361 __ b(hs, &ok);
357 Handle<Code> stack_check = isolate()->builtins()->StackCheck(); 362 Handle<Code> stack_check = isolate()->builtins()->StackCheck();
358 PredictableCodeSizeScope predictable(masm_); 363 PredictableCodeSizeScope predictable(masm_);
359 predictable.ExpectSize( 364 predictable.ExpectSize(
360 masm_->CallSize(stack_check, RelocInfo::CODE_TARGET)); 365 masm_->CallSize(stack_check, RelocInfo::CODE_TARGET));
(...skipping 5108 matching lines...) Expand 10 before | Expand all | Expand 10 after
5469 DCHECK(interrupt_address == 5474 DCHECK(interrupt_address ==
5470 isolate->builtins()->OsrAfterStackCheck()->entry()); 5475 isolate->builtins()->OsrAfterStackCheck()->entry());
5471 return OSR_AFTER_STACK_CHECK; 5476 return OSR_AFTER_STACK_CHECK;
5472 } 5477 }
5473 5478
5474 5479
5475 } // namespace internal 5480 } // namespace internal
5476 } // namespace v8 5481 } // namespace v8
5477 5482
5478 #endif // V8_TARGET_ARCH_ARM 5483 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/debug.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698