|
Decouple cc::FakeWebGraphicsContext3D from blink::WGC3D
cc_unittests that do not need a real OpenGL context use a stubbed-out
context provided by cc::TestGLES2Interface that forwards to a cc::TestWebGraphicsContext3D
stub that is subclassed by various unit tests. This makes cc::TWGC3D no longer subclass
blink::WebGraphicsContext3D to cut down on the blink dependency. This will enable moving
the test code to derive from TestGLES2Interface more directly down the road to cut out
the intermediates.
One subtle consequence of this change is that now that no class in the blink namespace is
in the inheritance chain for the test context subclasses, the clang checker now requires
OVERRIDE annotations.
BUG= 181120
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244152
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+260 lines, -251 lines) |
Patch |
 |
M |
cc/layers/texture_layer_unittest.cc
|
View
|
|
5 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
cc/output/delegating_renderer.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cc/output/gl_renderer.h
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/output/gl_renderer.cc
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/output/gl_renderer_unittest.cc
|
View
|
|
14 chunks |
+57 lines, -53 lines |
0 comments
|
Download
|
 |
M |
cc/output/output_surface_unittest.cc
|
View
|
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/resources/raster_worker_pool.cc
|
View
|
1
2
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
cc/resources/resource_update_controller_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cc/resources/texture_mailbox_deleter_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/test/fake_web_graphics_context_3d.h
|
View
|
|
5 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
cc/test/fake_web_graphics_context_3d.cc
|
View
|
|
4 chunks |
+5 lines, -13 lines |
0 comments
|
Download
|
 |
M |
cc/test/test_context_provider.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
cc/test/test_web_graphics_context_3d.h
|
View
|
|
5 chunks |
+130 lines, -101 lines |
0 comments
|
Download
|
 |
M |
cc/test/test_web_graphics_context_3d.cc
|
View
|
|
3 chunks |
+5 lines, -14 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest.cc
|
View
|
|
7 chunks |
+14 lines, -14 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest_context.cc
|
View
|
|
6 chunks |
+9 lines, -10 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest_copyrequest.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest_delegated.cc
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|