android_webview/browser/browser_view_renderer_impl.h - Issue 12697002: [Android WebView] Provide more information about WebView for web debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer_impl.h

Issue 12697002: [Android WebView] Provide more information about WebView for web debugging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments addressed Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/browser_view_renderer.h ('k') | android_webview/browser/browser_view_renderer_impl.cc » ('j') | android_webview/browser/browser_view_renderer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/browser_view_renderer_impl.h

diff --git a/android_webview/browser/browser_view_renderer_impl.h b/android_webview/browser/browser_view_renderer_impl.h

index 050645d70e8bd264b617e28fd7084d05cf1fd35b..9203558cc9fe9944a0b8edbf885f0d9bae9085dc 100644

--- a/android_webview/browser/browser_view_renderer_impl.h

+++ b/android_webview/browser/browser_view_renderer_impl.h

@@ -57,6 +57,9 @@ class BrowserViewRendererImpl

virtual void OnSizeChanged(int width, int height) OVERRIDE;

virtual void OnAttachedToWindow(int width, int height) OVERRIDE;

virtual void OnDetachedFromWindow() OVERRIDE;

+ virtual bool IsAttachedToWindow() OVERRIDE;

+ virtual bool IsViewVisible() OVERRIDE;

+ virtual gfx::Rect GetScreenRect() OVERRIDE;

// content::Compositor::Client implementation.

virtual void ScheduleComposite() OVERRIDE;

@@ -104,6 +107,7 @@ class BrowserViewRendererImpl

// Last View scroll before hardware rendering is triggered.

gfx::Point hw_rendering_scroll_;

+ bool view_attached_;

bool view_visible_;

bool compositor_visible_;

bool is_composite_pending_;