Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 1269683002: [interpreter] Adds interpreter cctests. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
Reviewers:
oth, titzer
CC:
v8-dev
Base URL:
ssh://rmcilroy.lon.corp.google.com///usr/local/google/code/v8_full/v8@interpreter_builtins
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Adds interpreter cctests. BUG=v8:4280 LOG=N Committed: https://crrev.com/6447b78f8e95520e063099d90625bc8b33384532 Cr-Commit-Position: refs/heads/master@{#30087}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix date #

Patch Set 3 : Use BytecodeArrayBuilder and drop all but Return test. #

Total comments: 2

Patch Set 4 : Add InterpreterCallable #

Patch Set 5 : Fix error in BytecodeArrayBuilder #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
M src/interpreter/interpreter.cc View 1 2 13 chunks +13 lines, -0 lines 0 comments Download
M src/isolate.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/interpreter/test-interpreter.cc View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (13 generated)
rmcilroy
Orion: This is the CL I mentioned which would be really nice to have a ...
5 years, 4 months ago (2015-07-30 08:09:04 UTC) #2
oth
Thanks, will use as template for bytecode generation tests. https://codereview.chromium.org/1269683002/diff/1/test/cctest/interpreter/test-interpreter.cc File test/cctest/interpreter/test-interpreter.cc (right): https://codereview.chromium.org/1269683002/diff/1/test/cctest/interpreter/test-interpreter.cc#newcode1 test/cctest/interpreter/test-interpreter.cc:1: ...
5 years, 4 months ago (2015-07-30 09:49:01 UTC) #3
rmcilroy
> Thanks, will use as template for bytecode generation tests. Great, you might also want ...
5 years, 4 months ago (2015-07-30 11:02:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269683002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269683002/60001
5 years, 4 months ago (2015-07-31 12:06:11 UTC) #7
rmcilroy
Ben, could you take a look please, thanks.
5 years, 4 months ago (2015-07-31 12:06:22 UTC) #9
rmcilroy
Ben, could you take a look please, thanks.
5 years, 4 months ago (2015-07-31 12:06:26 UTC) #10
titzer
https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc File test/cctest/interpreter/test-interpreter.cc (right): https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc#newcode31 test/cctest/interpreter/test-interpreter.cc:31: MaybeHandle<Object> Call() { Can we factor the Call() out ...
5 years, 4 months ago (2015-07-31 12:09:12 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/3255)
5 years, 4 months ago (2015-07-31 12:10:06 UTC) #13
rmcilroy
PTAL, thanks. https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc File test/cctest/interpreter/test-interpreter.cc (right): https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc#newcode31 test/cctest/interpreter/test-interpreter.cc:31: MaybeHandle<Object> Call() { On 2015/07/31 12:09:12, titzer ...
5 years, 4 months ago (2015-07-31 17:52:59 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269683002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269683002/80001
5 years, 4 months ago (2015-07-31 17:53:50 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8292)
5 years, 4 months ago (2015-07-31 18:07:01 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269683002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269683002/100001
5 years, 4 months ago (2015-07-31 21:02:49 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-31 21:26:38 UTC) #22
titzer
lgtm
5 years, 4 months ago (2015-08-03 09:46:30 UTC) #23
commit-bot: I haz the power
This CL has an open dependency (Issue 1266713004 Patch 60001). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-03 09:53:02 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269683002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269683002/120001
5 years, 4 months ago (2015-08-10 10:55:07 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 4 months ago (2015-08-10 11:20:27 UTC) #30
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 11:20:37 UTC) #31
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6447b78f8e95520e063099d90625bc8b33384532
Cr-Commit-Position: refs/heads/master@{#30087}

Powered by Google App Engine
This is Rietveld 408576698