service/rawdatastore/checkfilter.go - Issue 1269593002: Fix obviously broken error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/rawdatastore/checkfilter.go

Issue 1269593002: Fix obviously broken error handling. (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/rawdatastore/checkfilter.go

diff --git a/service/rawdatastore/checkfilter.go b/service/rawdatastore/checkfilter.go

index 002c965f5437ede665dab45770b842d0b19526bf..bf091358c7b0a21f0b17b99fc2623fea19845c61 100644

--- a/service/rawdatastore/checkfilter.go

+++ b/service/rawdatastore/checkfilter.go

@@ -70,9 +70,9 @@ func (tcf *checkFilter) PutMulti(keys []Key, vals []PropertyLoadSaver, cb PutMul

}

v := vals[i]

if v == nil {

- if !lme.Assign(i, errors.New("rawdatastore: PutMulti got nil vals entry")) {

- lme.Assign(i, v.Problem())

- }

+ lme.Assign(i, errors.New("rawdatastore: PutMulti got nil vals entry"))

+ } else {

+ lme.Assign(i, v.Problem())

}

if me := lme.Get(); me != nil {

« no previous file with comments | « no previous file | no next file » | no next file with comments »