Fix idle notification for background tab.

Fix idle notification for background tab.

The idle time handler should never return DONE or DO_SCAVENGE for
background tabs. Upon receiving DONE chrome will stop sending idle notifications.

BUG=chromium:515174
LOG=NO

Committed: https://crrev.com/3c9e8de5e45013b6042841dd7cea4e1b240dfa67
Cr-Commit-Position: refs/heads/master@{#29926}

[ulan, 2015-07-29 17:58:35]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2015-07-29 17:58:35]

ptal

[rmcilroy, 2015-07-29 18:11:04]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2015-07-29 18:11:04]

https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handl...
File src/heap/gc-idle-time-handler.cc (right):

https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handl...
src/heap/gc-idle-time-handler.cc:205: idle_times_which_made_no_progress_++;
Could this cause wrapping of idle_times_which_made_no_progress_? Maybe clap
idle_times_which_made_no_progress_ to be less than or equal to
kMaxNoProgressIdleTimes?

[ulan, 2015-07-29 18:21:30]

https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handl...
File src/heap/gc-idle-time-handler.cc (right):

https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handl...
src/heap/gc-idle-time-handler.cc:205: idle_times_which_made_no_progress_++;
On 2015/07/29 18:11:04, rmcilroy (OOO until 10th Aug) wrote:
> Could this cause wrapping of idle_times_which_made_no_progress_? Maybe clap
> idle_times_which_made_no_progress_ to be less than or equal to
> kMaxNoProgressIdleTimes?
Thanks, rewrote to clap the counter.
Interval between background idle notifications is at least 1 second, so wrapping
can happen in 60 years. :)

[Hannes Payer (out of office), 2015-07-29 21:26:02]

lgtm

[rmcilroy, 2015-07-30 07:14:07]

https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handl...
File src/heap/gc-idle-time-handler.cc (right):

https://codereview.chromium.org/1269583002/diff/1/src/heap/gc-idle-time-handl...
src/heap/gc-idle-time-handler.cc:205: idle_times_which_made_no_progress_++;
On 2015/07/29 18:21:30, ulan wrote:
> On 2015/07/29 18:11:04, rmcilroy (OOO until 10th Aug) wrote:
> > Could this cause wrapping of idle_times_which_made_no_progress_? Maybe clap
> > idle_times_which_made_no_progress_ to be less than or equal to
> > kMaxNoProgressIdleTimes?
> Thanks, rewrote to clap the counter.
> Interval between background idle notifications is at least 1 second, so
wrapping
> can happen in 60 years. :)

Better safe than sorry ;). Thanks.

[rmcilroy, 2015-07-30 07:14:20]

lgtm++

[ulan, 2015-07-30 08:35:33]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2015-07-30 08:35:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1269583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1269583002/20001

[commit-bot: I haz the power, 2015-07-30 08:45:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-30 08:45:48]

Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8217)

[ulan, 2015-07-30 08:54:43]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-07-30 08:54:43]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1269583002/#ps40001
(title: "Typo")

[commit-bot: I haz the power, 2015-07-30 08:54:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1269583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1269583002/40001

[commit-bot: I haz the power, 2015-07-30 09:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-30 09:25:53]

Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8224)

[ulan, 2015-07-30 09:40:13]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-07-30 09:40:14]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1269583002/#ps60001
(title: "deflake TestIdleNotification by ensuring that sweeping is completed.")

[commit-bot: I haz the power, 2015-07-30 09:40:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1269583002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1269583002/60001

[commit-bot: I haz the power, 2015-07-30 10:38:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-30 10:38:41]

Patchset 4 (id:??) landed as
https://crrev.com/3c9e8de5e45013b6042841dd7cea4e1b240dfa67
Cr-Commit-Position: refs/heads/master@{#29926}