Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269563006: add helper to create RSXform w/ anchorPt (Closed)

Created:
5 years, 4 months ago by reed1
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add helper to create RSXform w/ anchorPt BUG=skia: Committed: https://skia.googlesource.com/skia/+/6b38eabc16c2c002d982e5ffbd376aa09c1781b7

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : don't post-translate by anchor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M include/core/SkRSXform.h View 1 2 1 chunk +22 lines, -4 lines 0 comments Download
M samplecode/SampleAtlas.cpp View 1 2 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
reed1
5 years, 4 months ago (2015-07-29 21:46:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269563006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269563006/1
5 years, 4 months ago (2015-07-29 21:46:21 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/2371)
5 years, 4 months ago (2015-07-29 21:56:32 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269563006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269563006/20001
5 years, 4 months ago (2015-07-29 21:58:38 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-29 22:11:33 UTC) #10
reed1
ptal
5 years, 4 months ago (2015-07-30 12:14:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269563006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269563006/40001
5 years, 4 months ago (2015-07-30 12:14:12 UTC) #13
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-07-30 12:14:13 UTC) #14
robertphillips
lgtm. We probably need a unit test for this guy now.
5 years, 4 months ago (2015-07-30 12:44:59 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 12:46:08 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6b38eabc16c2c002d982e5ffbd376aa09c1781b7

Powered by Google App Engine
This is Rietveld 408576698