Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: components/view_manager/gles2/mojo_gpu_memory_buffer.cc

Issue 1269503007: Unify graphics buffer format & usage enums for GpuMemoryBuffer & SurfaceFactoryOzone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add header to BUILD.gn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/view_manager/gles2/mojo_gpu_memory_buffer.cc
diff --git a/components/view_manager/gles2/mojo_gpu_memory_buffer.cc b/components/view_manager/gles2/mojo_gpu_memory_buffer.cc
index 29c15d113508de370a756aa381eb26929a787156..45450506c39ca409cb216be42a353c51afffe3e5 100644
--- a/components/view_manager/gles2/mojo_gpu_memory_buffer.cc
+++ b/components/view_manager/gles2/mojo_gpu_memory_buffer.cc
@@ -12,41 +12,40 @@ namespace gles2 {
namespace {
-int NumberOfPlanesForGpuMemoryBufferFormat(
- gfx::GpuMemoryBuffer::Format format) {
+int NumberOfPlanesForGpuMemoryBufferFormat(gfx::BufferFormat format) {
switch (format) {
- case gfx::GpuMemoryBuffer::ATC:
- case gfx::GpuMemoryBuffer::ATCIA:
- case gfx::GpuMemoryBuffer::DXT1:
- case gfx::GpuMemoryBuffer::DXT5:
- case gfx::GpuMemoryBuffer::ETC1:
- case gfx::GpuMemoryBuffer::R_8:
- case gfx::GpuMemoryBuffer::RGBA_4444:
- case gfx::GpuMemoryBuffer::RGBA_8888:
- case gfx::GpuMemoryBuffer::RGBX_8888:
- case gfx::GpuMemoryBuffer::BGRA_8888:
+ case gfx::BufferFormat::ATC:
+ case gfx::BufferFormat::ATCIA:
+ case gfx::BufferFormat::DXT1:
+ case gfx::BufferFormat::DXT5:
+ case gfx::BufferFormat::ETC1:
+ case gfx::BufferFormat::R_8:
+ case gfx::BufferFormat::RGBA_4444:
+ case gfx::BufferFormat::RGBA_8888:
+ case gfx::BufferFormat::RGBX_8888:
+ case gfx::BufferFormat::BGRA_8888:
return 1;
- case gfx::GpuMemoryBuffer::YUV_420:
+ case gfx::BufferFormat::YUV_420:
return 3;
}
NOTREACHED();
return 0;
}
-size_t SubsamplingFactor(gfx::GpuMemoryBuffer::Format format, int plane) {
+size_t SubsamplingFactor(gfx::BufferFormat format, int plane) {
switch (format) {
- case gfx::GpuMemoryBuffer::ATC:
- case gfx::GpuMemoryBuffer::ATCIA:
- case gfx::GpuMemoryBuffer::DXT1:
- case gfx::GpuMemoryBuffer::DXT5:
- case gfx::GpuMemoryBuffer::ETC1:
- case gfx::GpuMemoryBuffer::R_8:
- case gfx::GpuMemoryBuffer::RGBA_4444:
- case gfx::GpuMemoryBuffer::RGBA_8888:
- case gfx::GpuMemoryBuffer::RGBX_8888:
- case gfx::GpuMemoryBuffer::BGRA_8888:
+ case gfx::BufferFormat::ATC:
+ case gfx::BufferFormat::ATCIA:
+ case gfx::BufferFormat::DXT1:
+ case gfx::BufferFormat::DXT5:
+ case gfx::BufferFormat::ETC1:
+ case gfx::BufferFormat::R_8:
+ case gfx::BufferFormat::RGBA_4444:
+ case gfx::BufferFormat::RGBA_8888:
+ case gfx::BufferFormat::RGBX_8888:
+ case gfx::BufferFormat::BGRA_8888:
return 1;
- case gfx::GpuMemoryBuffer::YUV_420: {
+ case gfx::BufferFormat::YUV_420: {
static size_t factor[] = {1, 2, 2};
DCHECK_LT(static_cast<size_t>(plane), arraysize(factor));
return factor[plane];
@@ -56,39 +55,36 @@ size_t SubsamplingFactor(gfx::GpuMemoryBuffer::Format format, int plane) {
return 0;
}
-size_t StrideInBytes(size_t width,
- gfx::GpuMemoryBuffer::Format format,
- int plane) {
+size_t StrideInBytes(size_t width, gfx::BufferFormat format, int plane) {
switch (format) {
- case gfx::GpuMemoryBuffer::ATCIA:
- case gfx::GpuMemoryBuffer::DXT5:
+ case gfx::BufferFormat::ATCIA:
+ case gfx::BufferFormat::DXT5:
DCHECK_EQ(plane, 0);
return width;
- case gfx::GpuMemoryBuffer::ATC:
- case gfx::GpuMemoryBuffer::DXT1:
- case gfx::GpuMemoryBuffer::ETC1:
+ case gfx::BufferFormat::ATC:
+ case gfx::BufferFormat::DXT1:
+ case gfx::BufferFormat::ETC1:
DCHECK_EQ(plane, 0);
DCHECK_EQ(width % 2, 0u);
return width / 2;
- case gfx::GpuMemoryBuffer::R_8:
+ case gfx::BufferFormat::R_8:
return (width + 3) & ~0x3;
- case gfx::GpuMemoryBuffer::RGBA_4444:
+ case gfx::BufferFormat::RGBA_4444:
DCHECK_EQ(plane, 0);
return width * 2;
- case gfx::GpuMemoryBuffer::RGBA_8888:
- case gfx::GpuMemoryBuffer::RGBX_8888:
- case gfx::GpuMemoryBuffer::BGRA_8888:
+ case gfx::BufferFormat::RGBA_8888:
+ case gfx::BufferFormat::RGBX_8888:
+ case gfx::BufferFormat::BGRA_8888:
DCHECK_EQ(plane, 0);
return width * 4;
- case gfx::GpuMemoryBuffer::YUV_420:
+ case gfx::BufferFormat::YUV_420:
return width / SubsamplingFactor(format, plane);
}
NOTREACHED();
return 0;
}
-size_t BufferSizeInBytes(const gfx::Size& size,
- gfx::GpuMemoryBuffer::Format format) {
+size_t BufferSizeInBytes(const gfx::Size& size, gfx::BufferFormat format) {
size_t size_in_bytes = 0;
int num_planes = NumberOfPlanesForGpuMemoryBufferFormat(format);
for (int i = 0; i < num_planes; ++i) {
@@ -102,21 +98,20 @@ size_t BufferSizeInBytes(const gfx::Size& size,
MojoGpuMemoryBufferImpl::MojoGpuMemoryBufferImpl(
const gfx::Size& size,
- Format format,
+ gfx::BufferFormat format,
scoped_ptr<base::SharedMemory> shared_memory)
: size_(size),
format_(format),
shared_memory_(shared_memory.Pass()),
- mapped_(false) {
-}
+ mapped_(false) {}
MojoGpuMemoryBufferImpl::~MojoGpuMemoryBufferImpl() {
}
scoped_ptr<gfx::GpuMemoryBuffer> MojoGpuMemoryBufferImpl::Create(
const gfx::Size& size,
- Format format,
- Usage usage) {
+ gfx::BufferFormat format,
+ gfx::BufferUsage usage) {
size_t bytes = BufferSizeInBytes(size, format);
scoped_ptr<base::SharedMemory> shared_memory(new base::SharedMemory);
if (!shared_memory->CreateAnonymous(bytes))
@@ -155,7 +150,7 @@ bool MojoGpuMemoryBufferImpl::IsMapped() const {
return mapped_;
}
-gfx::GpuMemoryBuffer::Format MojoGpuMemoryBufferImpl::GetFormat() const {
+gfx::BufferFormat MojoGpuMemoryBufferImpl::GetFormat() const {
return format_;
}
« no previous file with comments | « components/view_manager/gles2/mojo_gpu_memory_buffer.h ('k') | components/view_manager/gles2/mojo_gpu_memory_buffer_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698