Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: cc/test/test_gpu_memory_buffer_manager.cc

Issue 1269503007: Unify graphics buffer format & usage enums for GpuMemoryBuffer & SurfaceFactoryOzone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add header to BUILD.gn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/test_gpu_memory_buffer_manager.h ('k') | cc/test/test_image_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/test_gpu_memory_buffer_manager.cc
diff --git a/cc/test/test_gpu_memory_buffer_manager.cc b/cc/test/test_gpu_memory_buffer_manager.cc
index c889cb7a46edff1d4491c8855623a67951c9ba6b..d70b74083c9ddef19ffc3f48653654935191e616 100644
--- a/cc/test/test_gpu_memory_buffer_manager.cc
+++ b/cc/test/test_gpu_memory_buffer_manager.cc
@@ -11,41 +11,40 @@
namespace cc {
namespace {
-int NumberOfPlanesForGpuMemoryBufferFormat(
- gfx::GpuMemoryBuffer::Format format) {
+int NumberOfPlanesForGpuMemoryBufferFormat(gfx::BufferFormat format) {
switch (format) {
- case gfx::GpuMemoryBuffer::ATC:
- case gfx::GpuMemoryBuffer::ATCIA:
- case gfx::GpuMemoryBuffer::DXT1:
- case gfx::GpuMemoryBuffer::DXT5:
- case gfx::GpuMemoryBuffer::ETC1:
- case gfx::GpuMemoryBuffer::R_8:
- case gfx::GpuMemoryBuffer::RGBA_4444:
- case gfx::GpuMemoryBuffer::RGBA_8888:
- case gfx::GpuMemoryBuffer::RGBX_8888:
- case gfx::GpuMemoryBuffer::BGRA_8888:
+ case gfx::BufferFormat::ATC:
+ case gfx::BufferFormat::ATCIA:
+ case gfx::BufferFormat::DXT1:
+ case gfx::BufferFormat::DXT5:
+ case gfx::BufferFormat::ETC1:
+ case gfx::BufferFormat::R_8:
+ case gfx::BufferFormat::RGBA_4444:
+ case gfx::BufferFormat::RGBA_8888:
+ case gfx::BufferFormat::RGBX_8888:
+ case gfx::BufferFormat::BGRA_8888:
return 1;
- case gfx::GpuMemoryBuffer::YUV_420:
+ case gfx::BufferFormat::YUV_420:
return 3;
}
NOTREACHED();
return 0;
}
-size_t SubsamplingFactor(gfx::GpuMemoryBuffer::Format format, int plane) {
+size_t SubsamplingFactor(gfx::BufferFormat format, int plane) {
switch (format) {
- case gfx::GpuMemoryBuffer::ATC:
- case gfx::GpuMemoryBuffer::ATCIA:
- case gfx::GpuMemoryBuffer::DXT1:
- case gfx::GpuMemoryBuffer::DXT5:
- case gfx::GpuMemoryBuffer::ETC1:
- case gfx::GpuMemoryBuffer::R_8:
- case gfx::GpuMemoryBuffer::RGBA_4444:
- case gfx::GpuMemoryBuffer::RGBA_8888:
- case gfx::GpuMemoryBuffer::RGBX_8888:
- case gfx::GpuMemoryBuffer::BGRA_8888:
+ case gfx::BufferFormat::ATC:
+ case gfx::BufferFormat::ATCIA:
+ case gfx::BufferFormat::DXT1:
+ case gfx::BufferFormat::DXT5:
+ case gfx::BufferFormat::ETC1:
+ case gfx::BufferFormat::R_8:
+ case gfx::BufferFormat::RGBA_4444:
+ case gfx::BufferFormat::RGBA_8888:
+ case gfx::BufferFormat::RGBX_8888:
+ case gfx::BufferFormat::BGRA_8888:
return 1;
- case gfx::GpuMemoryBuffer::YUV_420: {
+ case gfx::BufferFormat::YUV_420: {
static size_t factor[] = {1, 2, 2};
DCHECK_LT(static_cast<size_t>(plane), arraysize(factor));
return factor[plane];
@@ -55,39 +54,36 @@ size_t SubsamplingFactor(gfx::GpuMemoryBuffer::Format format, int plane) {
return 0;
}
-size_t StrideInBytes(size_t width,
- gfx::GpuMemoryBuffer::Format format,
- int plane) {
+size_t StrideInBytes(size_t width, gfx::BufferFormat format, int plane) {
switch (format) {
- case gfx::GpuMemoryBuffer::ATCIA:
- case gfx::GpuMemoryBuffer::DXT5:
+ case gfx::BufferFormat::ATCIA:
+ case gfx::BufferFormat::DXT5:
DCHECK_EQ(plane, 0);
return width;
- case gfx::GpuMemoryBuffer::ATC:
- case gfx::GpuMemoryBuffer::DXT1:
- case gfx::GpuMemoryBuffer::ETC1:
+ case gfx::BufferFormat::ATC:
+ case gfx::BufferFormat::DXT1:
+ case gfx::BufferFormat::ETC1:
DCHECK_EQ(plane, 0);
DCHECK_EQ(width % 2, 0u);
return width / 2;
- case gfx::GpuMemoryBuffer::R_8:
+ case gfx::BufferFormat::R_8:
return (width + 3) & ~0x3;
- case gfx::GpuMemoryBuffer::RGBA_4444:
+ case gfx::BufferFormat::RGBA_4444:
DCHECK_EQ(plane, 0);
return width * 2;
- case gfx::GpuMemoryBuffer::RGBA_8888:
- case gfx::GpuMemoryBuffer::RGBX_8888:
- case gfx::GpuMemoryBuffer::BGRA_8888:
+ case gfx::BufferFormat::RGBA_8888:
+ case gfx::BufferFormat::RGBX_8888:
+ case gfx::BufferFormat::BGRA_8888:
DCHECK_EQ(plane, 0);
return width * 4;
- case gfx::GpuMemoryBuffer::YUV_420:
+ case gfx::BufferFormat::YUV_420:
return width / SubsamplingFactor(format, plane);
}
NOTREACHED();
return 0;
}
-size_t BufferSizeInBytes(const gfx::Size& size,
- gfx::GpuMemoryBuffer::Format format) {
+size_t BufferSizeInBytes(const gfx::Size& size, gfx::BufferFormat format) {
size_t size_in_bytes = 0;
int num_planes = NumberOfPlanesForGpuMemoryBufferFormat(format);
for (int i = 0; i < num_planes; ++i) {
@@ -100,7 +96,7 @@ size_t BufferSizeInBytes(const gfx::Size& size,
class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
public:
GpuMemoryBufferImpl(const gfx::Size& size,
- Format format,
+ gfx::BufferFormat format,
scoped_ptr<base::SharedMemory> shared_memory)
: size_(size),
format_(format),
@@ -128,7 +124,7 @@ class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
mapped_ = false;
}
bool IsMapped() const override { return mapped_; }
- Format GetFormat() const override { return format_; }
+ gfx::BufferFormat GetFormat() const override { return format_; }
void GetStride(int* stride) const override {
int num_planes = NumberOfPlanesForGpuMemoryBufferFormat(format_);
for (int i = 0; i < num_planes; ++i)
@@ -151,7 +147,7 @@ class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
private:
const gfx::Size size_;
- gfx::GpuMemoryBuffer::Format format_;
+ gfx::BufferFormat format_;
scoped_ptr<base::SharedMemory> shared_memory_;
bool mapped_;
};
@@ -165,10 +161,9 @@ TestGpuMemoryBufferManager::~TestGpuMemoryBufferManager() {
}
scoped_ptr<gfx::GpuMemoryBuffer>
-TestGpuMemoryBufferManager::AllocateGpuMemoryBuffer(
- const gfx::Size& size,
- gfx::GpuMemoryBuffer::Format format,
- gfx::GpuMemoryBuffer::Usage usage) {
+TestGpuMemoryBufferManager::AllocateGpuMemoryBuffer(const gfx::Size& size,
+ gfx::BufferFormat format,
+ gfx::BufferUsage usage) {
scoped_ptr<base::SharedMemory> shared_memory(new base::SharedMemory);
if (!shared_memory->CreateAnonymous(BufferSizeInBytes(size, format)))
return nullptr;
« no previous file with comments | « cc/test/test_gpu_memory_buffer_manager.h ('k') | cc/test/test_image_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698