Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: gpu/command_buffer/service/image_factory.h

Issue 1269503007: Unify graphics buffer format & usage enums for GpuMemoryBuffer & SurfaceFactoryOzone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: constrain includes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GPU_COMMAND_BUFFER_SERVICE_IMAGE_FACTORY_H_ 5 #ifndef GPU_COMMAND_BUFFER_SERVICE_IMAGE_FACTORY_H_
6 #define GPU_COMMAND_BUFFER_SERVICE_IMAGE_FACTORY_H_ 6 #define GPU_COMMAND_BUFFER_SERVICE_IMAGE_FACTORY_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "gpu/gpu_export.h" 9 #include "gpu/gpu_export.h"
10 #include "ui/gfx/geometry/size.h" 10 #include "ui/gfx/geometry/size.h"
11 #include "ui/gfx/gpu_memory_buffer.h" 11 #include "ui/gfx/gpu_memory_buffer.h"
12 12
13 namespace gfx { 13 namespace gfx {
14 class GLImage; 14 class GLImage;
15 } 15 }
16 16
17 namespace gpu { 17 namespace gpu {
18 struct Capabilities; 18 struct Capabilities;
19 19
20 class GPU_EXPORT ImageFactory { 20 class GPU_EXPORT ImageFactory {
21 public: 21 public:
22 ImageFactory(); 22 ImageFactory();
23 23
24 // Returns a valid GpuMemoryBuffer format given a valid internalformat as 24 // Returns a valid GpuMemoryBuffer format given a valid internalformat as
25 // defined by CHROMIUM_gpu_memory_buffer_image. 25 // defined by CHROMIUM_gpu_memory_buffer_image.
26 static gfx::GpuMemoryBuffer::Format ImageFormatToGpuMemoryBufferFormat( 26 static gfx::BufferFormat ImageFormatToGpuMemoryBufferFormat(
27 unsigned internalformat); 27 unsigned internalformat);
28 28
29 // Returns a valid GpuMemoryBuffer usage given a valid usage as defined by 29 // Returns a valid GpuMemoryBuffer usage given a valid usage as defined by
30 // CHROMIUM_gpu_memory_buffer_image. 30 // CHROMIUM_gpu_memory_buffer_image.
31 static gfx::GpuMemoryBuffer::Usage ImageUsageToGpuMemoryBufferUsage( 31 static gfx::BufferUsage ImageUsageToGpuMemoryBufferUsage(unsigned usage);
32 unsigned usage);
33 32
34 // Returns true if |internalformat| is compatible with |format|. 33 // Returns true if |internalformat| is compatible with |format|.
35 static bool IsImageFormatCompatibleWithGpuMemoryBufferFormat( 34 static bool IsImageFormatCompatibleWithGpuMemoryBufferFormat(
36 unsigned internalformat, 35 unsigned internalformat,
37 gfx::GpuMemoryBuffer::Format format); 36 gfx::BufferFormat format);
38 37
39 // Returns true if |format| is supported by |capabilities|. 38 // Returns true if |format| is supported by |capabilities|.
40 static bool IsGpuMemoryBufferFormatSupported( 39 static bool IsGpuMemoryBufferFormatSupported(
41 gfx::GpuMemoryBuffer::Format format, 40 gfx::BufferFormat format,
42 const Capabilities& capabilities); 41 const Capabilities& capabilities);
43 42
44 // Returns true if |size| is valid for |format|. 43 // Returns true if |size| is valid for |format|.
45 static bool IsImageSizeValidForGpuMemoryBufferFormat( 44 static bool IsImageSizeValidForGpuMemoryBufferFormat(
46 const gfx::Size& size, 45 const gfx::Size& size,
47 gfx::GpuMemoryBuffer::Format format); 46 gfx::BufferFormat format);
48 47
49 // Creates a GLImage instance for GPU memory buffer identified by |handle|. 48 // Creates a GLImage instance for GPU memory buffer identified by |handle|.
50 // |client_id| should be set to the client requesting the creation of instance 49 // |client_id| should be set to the client requesting the creation of instance
51 // and can be used by factory implementation to verify access rights. 50 // and can be used by factory implementation to verify access rights.
52 virtual scoped_refptr<gfx::GLImage> CreateImageForGpuMemoryBuffer( 51 virtual scoped_refptr<gfx::GLImage> CreateImageForGpuMemoryBuffer(
53 const gfx::GpuMemoryBufferHandle& handle, 52 const gfx::GpuMemoryBufferHandle& handle,
54 const gfx::Size& size, 53 const gfx::Size& size,
55 gfx::GpuMemoryBuffer::Format format, 54 gfx::BufferFormat format,
56 unsigned internalformat, 55 unsigned internalformat,
57 int client_id) = 0; 56 int client_id) = 0;
58 57
59 protected: 58 protected:
60 virtual ~ImageFactory(); 59 virtual ~ImageFactory();
61 }; 60 };
62 61
63 } // namespace gpu 62 } // namespace gpu
64 63
65 #endif // GPU_COMMAND_BUFFER_SERVICE_IMAGE_FACTORY_H_ 64 #endif // GPU_COMMAND_BUFFER_SERVICE_IMAGE_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698