Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/api/webdata/web_data_service_base.h

Issue 12695015: Split Autofill webdata (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Win build Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/api/webdata/autofill_web_data_service.h ('k') | chrome/browser/memory_purger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/api/webdata/web_data_service_base.h
diff --git a/chrome/browser/api/webdata/web_data_service_base.h b/chrome/browser/api/webdata/web_data_service_base.h
index 7a91a43b58d0ffbbb17515d1f9f71f93cf6d7861..22b00b8542f7a3b6e4cfdbc26e94709b3524eda7 100644
--- a/chrome/browser/api/webdata/web_data_service_base.h
+++ b/chrome/browser/api/webdata/web_data_service_base.h
@@ -39,7 +39,13 @@ class WebDataServiceBase
// |callback| will only be invoked on error, and only if
// |callback.is_null()| evaluates to false.
- WebDataServiceBase(const base::FilePath& path,
+ //
+ // The ownership of |wdbs| is shared, with the primary owner being the
+ // WebDataServiceWrapper, and secondary owners being subclasses of
+ // WebDataServiceBase, which receive |wdbs| upon construction. The
+ // WebDataServiceWrapper handles the initializing and shutting down and of
+ // the |wdbs| object.
+ WebDataServiceBase(scoped_refptr<WebDatabaseService> wdbs,
const ProfileErrorCallback& callback);
// Cancel any pending request. You need to call this method if your
@@ -93,7 +99,7 @@ class WebDataServiceBase
virtual void ShutdownOnDBThread();
// Our database service.
- scoped_ptr<WebDatabaseService> wdbs_;
+ scoped_refptr<WebDatabaseService> wdbs_;
// True if we've received a notification that the WebDatabase has loaded.
bool db_loaded_;
@@ -103,11 +109,6 @@ class WebDataServiceBase
content::BrowserThread::UI>;
friend class base::DeleteHelper<WebDataServiceBase>;
- // TODO(caitkp): Get rid of this once we fully split
- // AutofillWebDataService and WebDatabaseService away from
- // WebDataService.
- base::FilePath path_;
-
ProfileErrorCallback profile_error_callback_;
// This makes the destructor public, and thus allows us to aggregate
« no previous file with comments | « chrome/browser/api/webdata/autofill_web_data_service.h ('k') | chrome/browser/memory_purger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698