Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: chrome/browser/webdata/web_data_service_unittest.cc

Issue 12695015: Split Autofill webdata (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge to 12853004 (move table creation to factory) Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_data_service_unittest.cc
diff --git a/chrome/browser/webdata/web_data_service_unittest.cc b/chrome/browser/webdata/web_data_service_unittest.cc
index 585d36c452b11f288a40300f6b7f254a2fef407c..150ffff9f2fa3c646c0e5da4feada1e3ef68fd34 100644
--- a/chrome/browser/webdata/web_data_service_unittest.cc
+++ b/chrome/browser/webdata/web_data_service_unittest.cc
@@ -22,6 +22,7 @@
#include "chrome/browser/webdata/autofill_table.h"
#include "chrome/browser/webdata/web_data_service.h"
#include "chrome/browser/webdata/web_data_service_test_util.h"
+#include "chrome/browser/webdata/web_database_service.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/test/base/thread_observer_helper.h"
@@ -77,16 +78,23 @@ class WebDataServiceTest : public testing::Test {
db_thread_.Start();
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+
base::FilePath path = temp_dir_.path().AppendASCII("TestWebDB");
- wds_ = new WebDataService(path, WebDataServiceBase::ProfileErrorCallback());
- // Need to add at least one table so the database gets created.
- wds_->AddTable(scoped_ptr<WebDatabaseTable>(new AutofillTable).Pass());
+
+ wdbs_ = new WebDatabaseService(path);
+ wdbs_->AddTable(scoped_ptr<WebDatabaseTable>(new AutofillTable()));
+ wdbs_->LoadDatabase(WebDatabaseService::InitCallback());
+
+ wds_ = new WebDataService(wdbs_,
+ WebDataServiceBase::ProfileErrorCallback());
wds_->Init();
}
virtual void TearDown() {
wds_->ShutdownOnUIThread();
+ wdbs_->ShutdownDatabase();
wds_ = NULL;
+ wdbs_ = NULL;
WaitForDatabaseThread();
MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
@@ -108,6 +116,7 @@ class WebDataServiceTest : public testing::Test {
content::TestBrowserThread db_thread_;
base::FilePath profile_dir_;
scoped_refptr<WebDataService> wds_;
+ scoped_refptr<WebDatabaseService> wdbs_;
base::ScopedTempDir temp_dir_;
};

Powered by Google App Engine
This is Rietveld 408576698