Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/browser/webdata/web_data_service_base.cc

Issue 12695015: Split Autofill webdata (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge to 12853004 (move table creation to factory) Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_data_service_base.cc
diff --git a/chrome/browser/webdata/web_data_service_base.cc b/chrome/browser/webdata/web_data_service_base.cc
index 25b1e721674f9d1525ff4d2d9d15f5aae20cad7c..19b4464e5fd50361f3628cd7e2d299f12b08a9d1 100644
--- a/chrome/browser/webdata/web_data_service_base.cc
+++ b/chrome/browser/webdata/web_data_service_base.cc
@@ -29,10 +29,11 @@ using base::Bind;
using base::Time;
using content::BrowserThread;
-WebDataServiceBase::WebDataServiceBase(const base::FilePath& path,
- const ProfileErrorCallback& callback)
- : db_loaded_(false),
- path_(path),
+WebDataServiceBase::WebDataServiceBase(
+ scoped_refptr<WebDatabaseService> wdbs,
+ const ProfileErrorCallback& callback)
+ : wdbs_(wdbs),
+ db_loaded_(false),
profile_error_callback_(callback) {
// WebDataService requires DB thread if instantiated.
// Set WebDataServiceFactory::GetInstance()->SetTestingFactory(&profile, NULL)
@@ -45,12 +46,10 @@ void WebDataServiceBase::ShutdownOnUIThread() {
BrowserThread::PostTask(
BrowserThread::DB, FROM_HERE,
base::Bind(&WebDataServiceBase::ShutdownOnDBThread, this));
- ShutdownDatabase();
}
void WebDataServiceBase::AddTable(scoped_ptr<WebDatabaseTable> table) {
- if (!wdbs_.get())
- wdbs_.reset(new WebDatabaseService(path_));
+ DCHECK(wdbs_.get());
wdbs_->AddTable(table.Pass());
}
@@ -100,7 +99,6 @@ base::SupportsUserData* WebDataServiceBase::GetDBUserData() {
WebDataServiceBase::~WebDataServiceBase() {
DCHECK(!db_thread_user_data_.get()) << "Forgot to call ShutdownOnUIThread?";
- wdbs_.reset();
}
void WebDataServiceBase::ShutdownOnDBThread() {

Powered by Google App Engine
This is Rietveld 408576698