Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/browser/api/webdata/web_data_service_base.h

Issue 12695015: Split Autofill webdata (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge to 12853004 (move table creation to factory) Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/api/webdata/web_data_service_base.h
diff --git a/chrome/browser/api/webdata/web_data_service_base.h b/chrome/browser/api/webdata/web_data_service_base.h
index 7a91a43b58d0ffbbb17515d1f9f71f93cf6d7861..0b70c716a38f505041a59f1f51fefb6fc0db251c 100644
--- a/chrome/browser/api/webdata/web_data_service_base.h
+++ b/chrome/browser/api/webdata/web_data_service_base.h
@@ -39,8 +39,9 @@ class WebDataServiceBase
// |callback| will only be invoked on error, and only if
// |callback.is_null()| evaluates to false.
dhollowa 2013/03/21 16:44:07 nit: Comment on |wdbs| and the nature of the share
Cait (Slow) 2013/03/21 23:23:27 Done.
- WebDataServiceBase(const base::FilePath& path,
- const ProfileErrorCallback& callback);
+ WebDataServiceBase(
+ scoped_refptr<WebDatabaseService> wdbs,
+ const ProfileErrorCallback& callback);
// Cancel any pending request. You need to call this method if your
// WebDataServiceConsumer is about to be deleted.
@@ -93,7 +94,7 @@ class WebDataServiceBase
virtual void ShutdownOnDBThread();
// Our database service.
- scoped_ptr<WebDatabaseService> wdbs_;
+ scoped_refptr<WebDatabaseService> wdbs_;
// True if we've received a notification that the WebDatabase has loaded.
bool db_loaded_;
@@ -103,11 +104,6 @@ class WebDataServiceBase
content::BrowserThread::UI>;
friend class base::DeleteHelper<WebDataServiceBase>;
- // TODO(caitkp): Get rid of this once we fully split
- // AutofillWebDataService and WebDatabaseService away from
- // WebDataService.
- base::FilePath path_;
-
ProfileErrorCallback profile_error_callback_;
// This makes the destructor public, and thus allows us to aggregate

Powered by Google App Engine
This is Rietveld 408576698