Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/webdata/DEPS

Issue 12695015: Split Autofill webdata (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Win build Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Webdata is being made into a component (it will end up at 2 # Webdata is being made into a component (it will end up at
3 # //components/webdata and not depend on //chrome), so we have these basic 3 # //components/webdata and not depend on //chrome), so we have these basic
4 # rules followed by temporary exceptions. Please don't add to the list of 4 # rules followed by temporary exceptions. Please don't add to the list of
5 # exceptions! 5 # exceptions!
6 "-chrome/browser", 6 "-chrome/browser",
7 "-chrome/common", 7 "-chrome/common",
8 "+chrome/browser/api/webdata", 8 "+chrome/browser/api/webdata",
9 "+chrome/browser/webdata", 9 "+chrome/browser/webdata",
10 "+components/encryptor", 10 "+components/encryptor",
11 11
12 # TODO(caitkp, kaiwang): Bring this list to zero. 12 # TODO(caitkp, kaiwang): Bring this list to zero.
13 # Do not add to the list of temporarily-allowed dependencies below, 13 # Do not add to the list of temporarily-allowed dependencies below,
14 # and please do not introduce more #includes of these files. 14 # and please do not introduce more #includes of these files.
15 "!chrome/browser/history/history_database.h", 15 "!chrome/browser/history/history_database.h",
16 "!chrome/browser/password_manager/ie7_password.h", 16 "!chrome/browser/password_manager/ie7_password.h",
17 "!chrome/browser/search_engines/search_terms_data.h", 17
18 "!chrome/browser/search_engines/template_url.h", 18 # TODO(caitkp): Remove this, at slightly lower priority - this is
19 "!chrome/browser/search_engines/template_url_id.h", 19 # just a set of header-only enums, so we can live with it
20 "!chrome/browser/search_engines/template_url_service.h", 20 # temporarily even after we componentize.
21 "!chrome/browser/ui/profile_error_dialog.h",
22 "!chrome/common/chrome_notification_types.h", 21 "!chrome/common/chrome_notification_types.h",
23 # Do not add to the list of temporarily-allowed dependencies above,
24 # and please do not introduce more #includes of these files.
25 ] 22 ]
26 23
27 specific_include_rules = { 24 specific_include_rules = {
28 'web_data_service_factory\.(h|cc)': [ 25 # These files are staying in //chrome, so no need to restrict.
29 "!chrome/browser/profiles/profile.h", 26
30 "!chrome/browser/profiles/profile_dependency_manager.h", 27 r'((autocomplete|autofill_profile)_syncable_service|web_data_service(_win)?(_fac tory)?)(_unittest)?\.(cc|h)':
31 "!chrome/browser/profiles/profile_keyed_service.h", 28 [
32 "!chrome/browser/profiles/profile_keyed_service_factory.h", 29 '+chrome/browser',
33 ] 30 '+chrome/common',
31 ],
32
33 # TODO(caitkp): Componentize all the different tables. For now, we
34 # write these rules so they don't add bad dependencies.
35 r'^(?!autofill)[a-z_]+_table(_unittest)?\.(cc|h)': [
36 "!chrome/browser/history/history_database.h",
37 "!chrome/browser/search_engines/search_terms_data.h",
38 "!chrome/browser/search_engines/template_url.h",
39 "!chrome/browser/search_engines/template_url_id.h",
40 "!chrome/browser/search_engines/template_url_service.h",
41 ],
42
43 # TODO(caitkp): Extract unit tests from //chrome, at lower priority
44 # than production code.
45 r'(.*_unittest|.*_test_util)\.(cc|h)': [
46 "+chrome/browser/webdata/web_data_service.h",
47 "+chrome/browser/webdata/web_data_service_factory.h",
48 ],
34 } 49 }
OLDNEW
« no previous file with comments | « chrome/browser/sync/test/integration/autofill_helper.cc ('k') | chrome/browser/webdata/autocomplete_syncable_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698