Split Autofill webdata

chrome/browser/webdata/web_data_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Chromium settings and storage represent user-selected preferences and
 // information and MUST not be extracted, overwritten or modified except
 // through Chromium defined APIs.
 
 #ifndef CHROME_BROWSER_WEBDATA_WEB_DATA_SERVICE_H__
 #define CHROME_BROWSER_WEBDATA_WEB_DATA_SERVICE_H__
@@ skipping 89 matching lines @@
 class WebDataServiceConsumer;
 
 class WebDataService
     : public WebDataServiceBase,
       public AutofillWebData {
  public:
   // Retrieve a WebDataService for the given context.
   static scoped_refptr<WebDataService> FromBrowserContext(
       content::BrowserContext* context);
 
-  explicit WebDataService(const ProfileErrorCallback& callback);
+  WebDataService(scoped_refptr<WebDatabaseService> wdbs,
+      const ProfileErrorCallback& callback);

[Jói, 2013/03/20 12:41:29]

indentation: indent to (

[Cait (Slow), 2013/03/20 22:21:10]

Done.

 
   // Notifies listeners on the UI thread that multiple changes have been made to
   // to Autofill records of the database.
   // NOTE: This method is intended to be called from the DB thread.  It
   // it asynchronously notifies listeners on the UI thread.
   // |web_data_service| may be NULL for testing purposes.
   static void NotifyOfMultipleAutofillChanges(WebDataService* web_data_service);
 
-
-
   //////////////////////////////////////////////////////////////////////////////
   //
   // Keywords
   //
   //////////////////////////////////////////////////////////////////////////////
 
   // As the database processes requests at a later date, all deletion is
   // done on the background thread.
   //
   // Many of the keyword related methods do not return a handle. This is because
@@ skipping 160 matching lines @@
   friend class TemplateURLServiceTestingProfile;
   friend class WebDataServiceTest;
   friend class WebDataRequest;
 
   // For unit tests, passes a null callback.
   WebDataService();
 
   virtual ~WebDataService();
 
  private:
-  //////////////////////////////////////////////////////////////////////////////
-  //
-  // The following methods are only invoked in the web data service thread.

[Jói, 2013/03/20 12:41:29]

Is there a reason to remove this comment? Maybe just change "web data service
thread" to "DB thread"

[Cait (Slow), 2013/03/20 22:21:10]

Done.

-  //
-  //////////////////////////////////////////////////////////////////////////////
 
   //////////////////////////////////////////////////////////////////////////////
   //
   // Keywords.
   //
   //////////////////////////////////////////////////////////////////////////////
   WebDatabase::State AddKeywordImpl(
       const TemplateURLData& data, WebDatabase* db);
   WebDatabase::State RemoveKeywordImpl(
       TemplateURLID id, WebDatabase* db);
@@ skipping 103 matching lines @@
 
   // Callbacks to ensure that sensitive info is destroyed if request is
   // cancelled.
   void DestroyAutofillProfileResult(const WDTypedResult* result);
   void DestroyAutofillCreditCardResult(const WDTypedResult* result);
 
   DISALLOW_COPY_AND_ASSIGN(WebDataService);
 };
 
 #endif  // CHROME_BROWSER_WEBDATA_WEB_DATA_SERVICE_H__