Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1269483004: Remove redundant null check for AudioBus (Closed)

Created:
5 years, 4 months ago by Srirama
Modified:
5 years, 4 months ago
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove redundant null check for AudioBus In HTMLMediaElement::AudioSourceProviderImpl::provideInput there is an assert as well as null check for AudioBus. At the call site MediaElementAudioSourceHandler::process() AudioBus is directly used without any validation. So it is enough to keep the assert and remove the null check for AudioBus. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Srirama
PTAL
5 years, 4 months ago (2015-08-03 11:40:12 UTC) #2
philipj_slow
LGTM if rtoy@ things it's OK.
5 years, 4 months ago (2015-08-03 11:45:27 UTC) #4
Raymond Toy
On 2015/08/03 11:45:27, philipj wrote: > LGTM if rtoy@ things it's OK. lgtm too.
5 years, 4 months ago (2015-08-03 15:38:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269483004/1
5 years, 4 months ago (2015-08-03 16:26:34 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 16:29:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199899

Powered by Google App Engine
This is Rietveld 408576698