Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: Source/bindings/core/v8/V8BindingMacros.h

Issue 1269443002: Introduce FlexibleArrayBufferView and TypedFlexibleArrayBufferView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8BindingMacros.h
diff --git a/Source/bindings/core/v8/V8BindingMacros.h b/Source/bindings/core/v8/V8BindingMacros.h
index 2377e9d0c1445e71a67a83ba53490c01fedf4887..b343a92da20ab518d3dc51425f9f3813da0209a2 100644
--- a/Source/bindings/core/v8/V8BindingMacros.h
+++ b/Source/bindings/core/v8/V8BindingMacros.h
@@ -46,6 +46,10 @@ namespace blink {
if (UNLIKELY(!var.prepare())) \
return retVal;
+#define SMALL_ARRAY_BUFFER_VIEW_STORAGE(value) \
haraken 2015/07/30 14:54:57 I'd rename this to allocateFlexibleArrayBufferView
haraken 2015/07/30 14:54:57 Add a comment about what this is doing.
Michael Lippautz 2015/07/30 17:06:14 Done.
Michael Lippautz 2015/07/30 17:06:15 Done.
+ (value->IsArrayBufferView() && (value.As<v8::ArrayBufferView>()->ByteLength() <= 128) ? alloca(value.As<v8::ArrayBufferView>()->ByteLength()) : nullptr)
jochen (gone - plz use gerrit) 2015/07/30 14:30:06 should we change the default for on-heap typed arr
Michael Lippautz 2015/07/30 17:06:14 Changed to 64. Let's keep it in sync with V8's typ
+
+
jochen (gone - plz use gerrit) 2015/07/30 14:30:06 nit. only one empty line
Michael Lippautz 2015/07/30 17:06:15 Done.
template <typename T>
inline bool v8Call(v8::Maybe<T> maybe, T& outVariable)
{

Powered by Google App Engine
This is Rietveld 408576698