Introduce FlexibleArrayBufferView and TypedFlexibleArrayBufferView

Source/bindings/scripts/v8_types.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 166 matching lines @@
     if base_idl_type in CPP_SPECIAL_CONVERSION_RULES:
         return CPP_SPECIAL_CONVERSION_RULES[base_idl_type]
 
     if base_idl_type in NON_WRAPPER_TYPES:
         return ('PassRefPtr<%s>' if used_as_rvalue_type else 'RefPtr<%s>') % base_idl_type
     if idl_type.is_string_type:
         if not raw_type:
             return 'String'
         return 'V8StringResource<%s>' % string_mode()
 
-    if idl_type.is_array_buffer_or_view and raw_type:
-        return idl_type.implemented_as + '*'
+    if idl_type.base_type == 'ArrayBufferView' and 'FlexibleArrayBufferView' in extended_attributes:
+        return 'FlexibleArrayBufferView'
+    if idl_type.base_type in TYPED_ARRAY_TYPES and 'FlexibleArrayBufferView' in extended_attributes:
+        return 'Flexible' + idl_type.base_type + 'View'
     if idl_type.is_interface_type:
         implemented_as_class = idl_type.implemented_as
         if raw_type or (used_as_rvalue_type and idl_type.is_garbage_collected):
             return implemented_as_class + '*'
         new_type = 'Member' if used_in_cpp_sequence else 'RawPtr'
         ptr_type = cpp_ptr_type(('PassRefPtr' if used_as_rvalue_type else 'RefPtr'), new_type, idl_type.gc_type)
         return cpp_template_type(ptr_type, implemented_as_class)
     if idl_type.is_dictionary:
         return base_idl_type
     if idl_type.is_union_type:
@@ skipping 170 matching lines @@
 
 
 def includes_for_type(idl_type, extended_attributes=None):
     idl_type = idl_type.preprocessed_type
     extended_attributes = extended_attributes or {}
 
     # Simple types
     base_idl_type = idl_type.base_type
     if base_idl_type in INCLUDES_FOR_TYPE:
         return INCLUDES_FOR_TYPE[base_idl_type]
+    if base_idl_type == 'ArrayBufferView' and 'FlexibleArrayBufferView' in extended_attributes:

[haraken, 2015/07/30 14:54:57]

Can we add this to INCLUDES_FOR_TYPE instead of hardcoding include files here?

I think we can just unconditionally include 8ArrayBufferView.h and
FlexibleArrayBufferView.h if the type is ArrayBufferView.

[Michael Lippautz, 2015/07/30 17:06:15]

Done.

+        return set(['bindings/core/v8/V8ArrayBufferView.h',
+                    'core/dom/FlexibleArrayBufferView.h'])
+    if idl_type.base_type in TYPED_ARRAY_TYPES and 'FlexibleArrayBufferView' in extended_attributes:

[haraken, 2015/07/30 14:54:57]

Ditto.

[Michael Lippautz, 2015/07/30 17:06:15]

For TYPED_ARRAY_TYPES we additionally need the
  bindings/<array_type>/v8/V8<array_type>.h

Returning a union here. If I miss something to write this better just tell me.

+        return set(['bindings/core/v8/V8ArrayBufferView.h',
+                    'core/dom/TypedFlexibleArrayBufferView.h',
+                    'bindings/%s/v8/V8%s.h' % (component_dir[base_idl_type],
+                                               base_idl_type)])
     if idl_type.is_basic_type:
         return set()
     if base_idl_type.endswith('ConstructorConstructor'):
         # FIXME: rename to NamedConstructor
         # FIXME: replace with a [NamedConstructorAttribute] extended attribute
         # Ending with 'ConstructorConstructor' indicates a named constructor,
         # and these do not have header files, as they are part of the generated
         # bindings for the interface
         return set()
     if base_idl_type.endswith('Constructor'):
@@ skipping 103 matching lines @@
     'octet': 'toUInt8({isolate}, {arguments})',
     'short': 'toInt16({isolate}, {arguments})',
     'unsigned short': 'toUInt16({isolate}, {arguments})',
     'long': 'toInt32({isolate}, {arguments})',
     'unsigned long': 'toUInt32({isolate}, {arguments})',
     'long long': 'toInt64({isolate}, {arguments})',
     'unsigned long long': 'toUInt64({isolate}, {arguments})',
     # Interface types
     'Dictionary': 'Dictionary({v8_value}, {isolate}, exceptionState)',
     'EventTarget': 'toEventTarget({isolate}, {v8_value})',
+    'FlexibleArrayBufferView': 'toFlexibleArrayBufferView({isolate}, {v8_value}, {variable_name}, SMALL_ARRAY_BUFFER_VIEW_STORAGE({v8_value}))',
     'NodeFilter': 'toNodeFilter({v8_value}, info.Holder(), ScriptState::current({isolate}))',
     'Promise': 'ScriptPromise::cast(ScriptState::current({isolate}), {v8_value})',
     'SerializedScriptValue': 'SerializedScriptValueFactory::instance().create({isolate}, {v8_value}, 0, 0, exceptionState)',
     'ScriptValue': 'ScriptValue(ScriptState::current({isolate}), {v8_value})',
     'Window': 'toDOMWindow({isolate}, {v8_value})',
     'XPathNSResolver': 'toXPathNSResolver(ScriptState::current({isolate}), {v8_value})',
 }
 
 
 def v8_conversion_needs_exception_state(idl_type):
@@ skipping 33 matching lines @@
 
     # Array or sequence types
     native_array_element_type = idl_type.native_array_element_type
     if native_array_element_type:
         return v8_value_to_cpp_value_array_or_sequence(native_array_element_type, v8_value, index, isolate)
 
     # Simple types
     idl_type = idl_type.preprocessed_type
     base_idl_type = idl_type.as_union_type.name if idl_type.is_union_type else idl_type.base_type
 
+    if base_idl_type == 'ArrayBufferView' and 'FlexibleArrayBufferView' in extended_attributes:
+        base_idl_type = 'FlexibleArrayBufferView'
+    if idl_type.base_type in TYPED_ARRAY_TYPES and 'FlexibleArrayBufferView' in extended_attributes:
+        base_idl_type = 'FlexibleArrayBufferView'

[haraken, 2015/07/30 14:54:57]

Shouldn't this be:

  'Flexible' + idl_type.base_type + 'View'

?

[Michael Lippautz, 2015/07/30 17:06:15]

Nope, both, FlexibleArrayBufferView and
TypedFlexibleArrayBufferView<WTFTypedArray>, filled using the same method: to
FlexibleArrayBufferView (line 512 this file).

+
     if idl_type.is_integer_type:
         configuration = 'NormalConversion'
         if 'EnforceRange' in extended_attributes:
             configuration = 'EnforceRange'
         elif 'Clamp' in extended_attributes:
             configuration = 'Clamp'
         arguments = ', '.join([v8_value, configuration, 'exceptionState'])
     elif idl_type.v8_conversion_needs_exception_state:
         arguments = ', '.join([v8_value, 'exceptionState'])
     else:
@@ skipping 76 matching lines @@
             # as the condition here would be wrong.
             if not idl_type.v8_conversion_needs_exception_state:
                 if use_exception_state:
                     check_expression = '!%s.prepare(exceptionState)' % variable_name
                 else:
                     check_expression = '!%s.prepare()' % variable_name
     elif not idl_type.v8_conversion_is_trivial:
         return {
             'error_message': 'no V8 -> C++ conversion for IDL type: %s' % idl_type.name
         }
+    elif idl_type.base_type == 'ArrayBufferView' and 'FlexibleArrayBufferView' in extended_attributes:
+        set_expression = cpp_value
+    elif idl_type.base_type in TYPED_ARRAY_TYPES and 'FlexibleArrayBufferView' in extended_attributes:

[haraken, 2015/07/30 14:54:57]

Slightly better:

elif 'FlexibleArrayBufferView' in extended_attributes:
  raise "..." if idl_type.base_type != 'ArrayBufferView' or idl_type.base_type
in TYPED_ARRAY_TYPES
  set_expression = cpp_calue

[Michael Lippautz, 2015/07/30 17:06:15]

Done. Rewrote using regular if though as your suggested solutions is apparently
not valid syntax :)

+        set_expression = cpp_value
     else:
         assign_expression = cpp_value
 
     # Types that don't need error handling, and simply assign a value to the
     # local variable.
 
     return {
         'assign_expression': assign_expression,
         'check_expression': check_expression,
         'cpp_type': this_cpp_type,
@@ skipping 337 matching lines @@
     number_of_nullable_member_types_union)
 
 
 def includes_nullable_type_union(idl_type):
     # http://heycam.github.io/webidl/#dfn-includes-a-nullable-type
     return idl_type.number_of_nullable_member_types == 1
 
 IdlTypeBase.includes_nullable_type = False
 IdlNullableType.includes_nullable_type = True
 IdlUnionType.includes_nullable_type = property(includes_nullable_type_union)