Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1269413003: Fix apptest runner retry logic and output parsing. (Closed)

Created:
5 years, 4 months ago by msw
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix apptest runner retry logic and output parsing. Fixing retry looping to bail on a success after a failure. Only add valid gtest_filter flags when no filter is specified. (don't try to filter using the 'mojo:apptest' name on crashes) Make the GTEST output parsing agnostic to colored output. BUG=509880 TEST=New Windows FYI bot retries failures/crashes as expected. R=sky@chromium.org Committed: https://crrev.com/8054d7869cb9e4022e63649a9335f46a80e3f7a7 Cr-Commit-Position: refs/heads/master@{#341994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M mojo/tools/mopy/gtest.py View 2 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 4 months ago (2015-08-05 18:49:13 UTC) #1
sky
LGTM - I think you're getting close to the point of wanting tests for this ...
5 years, 4 months ago (2015-08-05 21:30:52 UTC) #2
msw
On 2015/08/05 21:30:52, sky wrote: > LGTM - I think you're getting close to the ...
5 years, 4 months ago (2015-08-05 21:32:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269413003/1
5 years, 4 months ago (2015-08-05 21:33:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 22:48:35 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 22:49:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8054d7869cb9e4022e63649a9335f46a80e3f7a7
Cr-Commit-Position: refs/heads/master@{#341994}

Powered by Google App Engine
This is Rietveld 408576698