Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269383003: Remove SK_LEGACY_SKPOINT3_CTORS flag (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_LEGACY_SKPOINT3_CTORS flag Cannot land before Blink https://codereview.chromium.org/1274673002/ (Remove reliance on legacy Skia SkPoint3 ctors in FELighting.cpp) Committed: https://skia.googlesource.com/skia/+/d0cf9d831f7f4c98d48f52e6850db4ade1dd9422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/effects/SkLightingImageFilter.h View 1 chunk +1 line, -6 lines 0 comments Download
M include/effects/SkPoint3.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
robertphillips
5 years, 4 months ago (2015-08-05 14:19:30 UTC) #2
robertphillips
ping
5 years, 4 months ago (2015-08-06 13:44:49 UTC) #3
robertphillips
The Blink patch landed at 200052. The current version of Blink in Chrome is 200102.
5 years, 4 months ago (2015-08-06 13:50:08 UTC) #4
reed1
lgtm
5 years, 4 months ago (2015-08-06 13:56:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269383003/1
5 years, 4 months ago (2015-08-06 14:01:08 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 14:08:33 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d0cf9d831f7f4c98d48f52e6850db4ade1dd9422

Powered by Google App Engine
This is Rietveld 408576698