Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1269383002: Update yasm .gyp for tweaked ASAN bots. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update yasm .gyp for tweaked ASAN bots. They're not passing -fsanitize=address anymore, rather -fsanitize=address,bool,etc,etc,etc... NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6c17ca5905372cb956e532a18f09d4c0f560d01a

Patch Set 1 #

Patch Set 2 : absurdly fragile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gyp/yasm.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
5 years, 4 months ago (2015-08-05 14:38:37 UTC) #2
msarett
lgtm
5 years, 4 months ago (2015-08-05 14:40:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269383002/20001
5 years, 4 months ago (2015-08-05 15:51:25 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 15:58:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6c17ca5905372cb956e532a18f09d4c0f560d01a

Powered by Google App Engine
This is Rietveld 408576698