Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269343002: Retire StringTracker. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Retire StringTracker. BUG= Committed: https://crrev.com/af800bf6ad2a082be80e5e97a29d3c7f979cb707 Cr-Commit-Position: refs/heads/master@{#30031}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -103 lines) Patch
M src/api.h View 1 chunk +0 lines, -66 lines 0 comments Download
M src/api.cc View 1 4 chunks +3 lines, -9 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/isolate.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 4 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-05 11:34:17 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-05 11:35:33 UTC) #4
Michael Starzinger
LGTM.
5 years, 4 months ago (2015-08-05 11:36:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269343002/1
5 years, 4 months ago (2015-08-05 11:36:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8417)
5 years, 4 months ago (2015-08-05 11:47:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269343002/20001
5 years, 4 months ago (2015-08-05 13:32:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/8396)
5 years, 4 months ago (2015-08-05 13:46:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269343002/40001
5 years, 4 months ago (2015-08-05 14:18:00 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-05 15:12:58 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 15:13:54 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/af800bf6ad2a082be80e5e97a29d3c7f979cb707
Cr-Commit-Position: refs/heads/master@{#30031}

Powered by Google App Engine
This is Rietveld 408576698