Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: Source/core/html/HTMLTextFormControlElementTest.cpp

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.cpp ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTextFormControlElementTest.cpp
diff --git a/Source/core/html/HTMLTextFormControlElementTest.cpp b/Source/core/html/HTMLTextFormControlElementTest.cpp
index 9feac4b65437b595df95f181906f86766a717b22..064396204b0d06b9df7c3355895dbf9d084be491 100644
--- a/Source/core/html/HTMLTextFormControlElementTest.cpp
+++ b/Source/core/html/HTMLTextFormControlElementTest.cpp
@@ -94,16 +94,16 @@ void HTMLTextFormControlElementTest::forceLayoutFlag()
TEST_F(HTMLTextFormControlElementTest, SetSelectionRange)
{
- EXPECT_EQ(0, textControl().selectionStart());
- EXPECT_EQ(0, textControl().selectionEnd());
+ EXPECT_EQ(0u, textControl().selectionStart());
+ EXPECT_EQ(0u, textControl().selectionEnd());
textControl().setInnerEditorValue("Hello, text form.");
- EXPECT_EQ(0, textControl().selectionStart());
- EXPECT_EQ(0, textControl().selectionEnd());
+ EXPECT_EQ(0u, textControl().selectionStart());
+ EXPECT_EQ(0u, textControl().selectionEnd());
textControl().setSelectionRange(1, 3);
- EXPECT_EQ(1, textControl().selectionStart());
- EXPECT_EQ(3, textControl().selectionEnd());
+ EXPECT_EQ(1u, textControl().selectionStart());
+ EXPECT_EQ(3u, textControl().selectionEnd());
}
TEST_F(HTMLTextFormControlElementTest, SetSelectionRangeDoesNotCauseLayout)
@@ -214,7 +214,7 @@ TEST_F(HTMLTextFormControlElementTest, SpellCheckDoesNotCauseUpdateLayout)
Position newPosition(input->innerEditorElement()->firstChild(), 3);
VisibleSelection newSelection(newPosition, DOWNSTREAM);
document().frame()->selection().setSelection(newSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle | FrameSelection::DoNotUpdateAppearance);
- ASSERT_EQ(3, input->selectionStart());
+ ASSERT_EQ(3u, input->selectionStart());
OwnPtrWillBePersistent<SpellChecker> spellChecker(SpellChecker::create(page().frame()));
forceLayoutFlag();
« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.cpp ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698