Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: Source/core/html/HTMLTextAreaElement.idl

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLTextAreaElement.idl
diff --git a/Source/core/html/HTMLTextAreaElement.idl b/Source/core/html/HTMLTextAreaElement.idl
index ea7ca760f41738b09f32065c1b6f22482c9260d9..681b32faadb10b2b868d42d34d4d5d19aab21e7d 100644
--- a/Source/core/html/HTMLTextAreaElement.idl
+++ b/Source/core/html/HTMLTextAreaElement.idl
@@ -62,10 +62,8 @@ interface HTMLTextAreaElement : HTMLElement {
unsigned long start,
unsigned long end,
optional SelectionMode selectionMode = "preserve");
- // TODO(philipj): The start and end arguments should be unsigned long and
- // should not be optional.
- void setSelectionRange([Default=Undefined] optional long start,
- [Default=Undefined] optional long end,
+ void setSelectionRange(unsigned long start,
+ unsigned long end,
optional DOMString direction);
// HTML autocapitalize proposal

Powered by Google App Engine
This is Rietveld 408576698