Source/core/html/HTMLTextFormControlElement.h - Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElement.h

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/HTMLTextAreaElement.idl ('k') | Source/core/html/HTMLTextFormControlElement.cpp » ('j') | Source/core/html/HTMLTextFormControlElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTextFormControlElement.h

diff --git a/Source/core/html/HTMLTextFormControlElement.h b/Source/core/html/HTMLTextFormControlElement.h

index 906661dfbc87adbeddf081002595d84ecfed4abc..cbc6f00e6575fa73c1e4c5690f49e8bd95175c1d 100644

--- a/Source/core/html/HTMLTextFormControlElement.h

+++ b/Source/core/html/HTMLTextFormControlElement.h

@@ -77,8 +77,8 @@ public:

void select(NeedToDispatchSelectEvent = DispatchSelectEvent);

virtual void setRangeText(const String& replacement, ExceptionState&);

virtual void setRangeText(const String& replacement, unsigned start, unsigned end, const String& selectionMode, ExceptionState&);

- void setSelectionRange(int start, int end, const String& direction);

- void setSelectionRange(int start, int end, TextFieldSelectionDirection = SelectionHasNoDirection, NeedToDispatchSelectEvent = DispatchSelectEvent, SelectionOption = ChangeSelection);

+ void setSelectionRange(unsigned start, unsigned end, const String& direction);

+ void setSelectionRange(unsigned start, unsigned end, TextFieldSelectionDirection = SelectionHasNoDirection, NeedToDispatchSelectEvent = DispatchSelectEvent, SelectionOption = ChangeSelection);

PassRefPtrWillBeRawPtr<Range> selection() const;

virtual bool supportsAutocapitalize() const = 0;