LayoutTests/fast/forms/input-appearance-selection.html - Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/input-appearance-selection.html

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js ('k') | LayoutTests/fast/forms/selection-functions-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 function test () {	4 function test () {

5 var testField = document.getElementById('t1');	5 var testField = document.getElementById('t1');

6 var results = document.getElementById('result');	6 var results = document.getElementById('result');

7	7

8 testSelectionRange(1, 0, 0, 0, 0, testField, results);	8 testSelectionRange(1, 0, 0, 0, 0, testField, results);

9 testSelectionEnd(2, 17, 0, 17, testField, results);	9 testSelectionEnd(2, 17, 0, 17, testField, results);

10 testSelectionStart(3, 1, 1, 17, testField, results);	10 testSelectionStart(3, 1, 1, 17, testField, results);

11 testSelectionRange(4, 10, 3, 3, 3, testField, results);	11 testSelectionRange(4, 10, 3, 3, 3, testField, results);

12 testSelectionEnd(5, 2, 2, 2, testField, results);	12 testSelectionEnd(5, 2, 2, 2, testField, results);

13 testSelectionRange(6, 5, 4, 4, 4, testField, results);	13 testSelectionRange(6, 5, 4, 4, 4, testField, results);

14 testSelectionRange(7, -5, -4, 0, 0, testField, results);	14 testSelectionRange(7, -5, -4, 20, 20, testField, results);

15 testSelectionRange(8, -5, 80, 0, 20, testField, results);	15 testSelectionRange(8, -5, 80, 20, 20, testField, results);

16 testSelectionRange(9, 3, 12, 3, 12, testField, results);	16 testSelectionRange(9, 3, 12, 3, 12, testField, results);

17	17

18 }	18 }

19	19

20 function testSelectionRange (testNumber, start, end, expectedStart, expectedEnd, tf, res)	20 function testSelectionRange (testNumber, start, end, expectedStart, expectedEnd, tf, res)

21 {	21 {

22 tf.focus();	22 tf.focus();

23 tf.setSelectionRange(start, end);	23 tf.setSelectionRange(start, end);

24 res.innerHTML = res.innerHTML + "<br>Test " + testNumber + ": setSelectionRa nge(" + start + ", " + end + ")";	24 res.innerHTML = res.innerHTML + "<br>Test " + testNumber + ": setSelectionRa nge(" + start + ", " + end + ")";

25 if (tf.selectionStart == expectedStart && tf.selectionEnd == expectedEnd)	25 if (tf.selectionStart == expectedStart && tf.selectionEnd == expectedEnd)

(...skipping 25 matching lines...) Expand all Loading...
51 </script>	51 </script>

52 </head>	52 </head>

53 <body onload="test()">	53 <body onload="test()">

54 This tests the selection methods on the new text field.	54 This tests the selection methods on the new text field.

55 <p>	55 <p>

56 <input type="text" id="t1" style="-khtml-appearance:textfield" value="123456789 ABCDEFGHIJ"></input>	56 <input type="text" id="t1" style="-khtml-appearance:textfield" value="123456789 ABCDEFGHIJ"></input>

57 <div id="result"></div>	57 <div id="result"></div>

58 </p>	58 </p>

59 </body>	59 </body>

60 </html>	60 </html>

OLD	NEW